| Summary: | Tags within Split transaction not reporting correctly | ||
|---|---|---|---|
| Product: | [Applications] kmymoney | Reporter: | Michael Carpino <mfcarpino> |
| Component: | reports | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | antoine, codyregister, ralf.habacker |
| Priority: | NOR | ||
| Version: | git (master) | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/office/kmymoney/-/commit/d5a82fc7ebf1fa23874c5bb87f7a719df1529528 | Version Fixed In: | 5.2 |
| Sentry Crash Report: | |||
| Bug Depends on: | 412429 | ||
| Bug Blocks: | |||
| Attachments: |
Screenshot
test case from kmymoney build from master branch test case from a kmymoney build with older major version test case with several tag combinations |
||
|
Description
Michael Carpino
2019-04-10 12:54:40 UTC
fyi This problem also exists in the Stable AppImage Version 5.0.3-4f18e69 The reason for this bug is the same as with bug 412429 A related problem might have been reported on the forum at https://forum.kde.org/viewtopic.php?f=69&t=163345 Git commit 73f0314c34aa2cbf0a532c282cc9acb28e104267 by Ralf Habacker. Committed on 18/11/2019 at 10:44. Pushed by habacker into tag '4.8.5'. Fix 'Tags within Split transaction not reporting correctly' FIXED-IN:5.0.8 M +25 -12 kmymoney/reports/querytable.cpp https://commits.kde.org/kmymoney/73f0314c34aa2cbf0a532c282cc9acb28e104267 Git commit 9bc5781d057b58a8a8dc465fda542d004927a513 by Ralf Habacker. Committed on 13/12/2019 at 00:00. Pushed by habacker into branch '4.8'. Add support for showing tags on splits in tag report M +21 -35 kmymoney/reports/querytable.cpp https://commits.kde.org/kmymoney/9bc5781d057b58a8a8dc465fda542d004927a513 Created attachment 127719 [details]
Screenshot
Here is a report of "Transactions by Tag" The transactions on 11/13/19 and 11/25/19 are parts of two split transactions with tags on the splits but not on the parent transaction.
Issue is still present in the latest AppImage 5.0.8-feb8f9e. See attachment. The transactions on 11/13/19 and 11/25/19 are parts of two split transactions with tags on the splits, but no tag on the parent. The splits do not show up under the reports for their respective tags. > Issue is still present in the latest AppImage 5.0.8-feb8f9e. As can be seen from comment 5, a corresponding patch for 4.8 has been provided to the best of our knowledge. However, it is currently impossible to say whether this will not affect other reports. For the 5.0 branch, due to the extensive changes that have been made, it is not possible to say whether the patch works at all and does not additionally break other reports. This also applies to other changes for the reporting engine for https://phabricator.kde.org/D13803 (In reply to Ralf Habacker from comment #8) > As can be seen from comment 5, a corresponding patch for 4.8 has been > provided to the best of our knowledge. However, it is currently impossible > to say whether this will not affect other reports. There are two reasons for this: 1. due to the large number of report settings and the many enhancements and adjustments that have been made, the implementation of reports is in a state where adjustments and bug fixes are very susceptible to create hidden interference with other report types and variants, which may lead to deviations or missing results. Since the core of financial applications is the "correct" (in the sense of defined rules) processing and presentation of figures, errors in reports have a huge impact and reduce the reliability and usability of the application. 2. In addition, there are currently no comprehensive tests that allow a developer to quickly determine whether a change to the report implementation will cause unwanted interference. I can reproduce this issue. KMyMoney-5.1.0-74a8f0d-x86_64.AppImage, xubuntu 20.04 I discovered that the issue with Tags is more than a report problem and it's likely to be related to split Tags in general. When there is a split transaction and there is Tags associated with them the split transactions are reporting wrong when viewing them in the Tags List within KMM. The split transactions are properly recorded as a charge in my credit card account but when I view the split transaction in the Tags List it is showing as a Deposit which also reduces the balance by this amount. Consequently the balance figure is reporting incorrectly. To reproduce Follow the steps in my post of 2019-04-10 and enter the transaction as a payment. Then view the details of the post in the Tags List. Created attachment 165239 [details]
test case from kmymoney build from master branch
The attached file shows what happens when you add a transaction with splits where a tag has been added to each split. The added tags are not included in the tag list.
Created attachment 165242 [details]
test case from a kmymoney build with older major version
A comparison of this file with the test case with a kmymoney build from the Git master branch shows that the splits have no tag, which indicates that a tag cannot be created in the split editor. The input of a tag is ignored and no error message is displayed. However, this is a different error than described and therefore does not belong here.
(In reply to Ralf Habacker from comment #13) > Created attachment 165242 [details] > test case from a kmymoney build with older major version > > A comparison of this file with the test case with a kmymoney build from the > Git master branch shows that the splits have no tag, which indicates that a > tag cannot be created in the split editor. The input of a tag is ignored and > no error message is displayed. However, this is a different error than > described and therefore does not belong here. forwared this issue to bug 480358. Git commit d5a82fc7ebf1fa23874c5bb87f7a719df1529528 by Thomas Baumgart. Committed on 04/02/2024 at 12:59. Pushed by tbaumgart into branch 'master'. Fix reporting of tagged splits Reporting tagged transactions did not work properly due to the assignment of the tag to the wrong split. See commit 96a4ae27bb for a fix to that problem. For it to produce correct results in the report, the transactions may have to be edited so that the tag is assigned to the correct split. FIXED-IN: 5.2 M +45 -46 kmymoney/plugins/views/reports/core/querytable.cpp https://invent.kde.org/office/kmymoney/-/commit/d5a82fc7ebf1fa23874c5bb87f7a719df1529528 Git commit 796df584ef0bada68b6c98d75cd8a1af42c4b8ca by Thomas Baumgart. Committed on 04/02/2024 at 12:59. Pushed by tbaumgart into branch 'master'. Assign tag to the category split The initial implementation of tags assigned the selected tag to the split for the account the transaction was entered. This is not useful as the tag needs to be assigned to the category split. This change makes sure that the tag is assigned to the category split. Existing simple transactions can be fixed by opening them in the transaction editor and saving them again. Multi split transactions need to be fixed using the split editor. The above described fix only works for individually selected transactions. It is not supported when multiple transactions are selected. Related: bug 480360 M +11 -1 kmymoney/views/multitransactioneditor.cpp M +35 -4 kmymoney/views/newtransactioneditor.cpp https://invent.kde.org/office/kmymoney/-/commit/796df584ef0bada68b6c98d75cd8a1af42c4b8ca (In reply to Thomas Baumgart from comment #16) > Git commit 796df584ef0bada68b6c98d75cd8a1af42c4b8ca by Thomas Baumgart. > Committed on 04/02/2024 at 12:59. > Pushed by tbaumgart into branch 'master'. > > Existing simple transactions can be fixed by opening them in the > transaction editor and saving them again. Multi split transactions need > to be fixed using the split editor. > > The above described fix only works for individually selected > transactions. It is not supported when multiple transactions are > selected. Can this be fixed automatically when loading the file? Created attachment 165648 [details]
test case with several tag combinations
The contained transaction with post date 2024-01-28 shows an issue: when opening split editor and pressing okay there is 'tag1' two times shown in the transaction tag line
Git commit 62cbaeacb9ceb5a6b580c68cf217df6f6daa968f by Thomas Baumgart. Committed on 08/02/2024 at 07:43. Pushed by tbaumgart into branch 'master'. Clear existing tags from tagContainer before reloading them M +2 -0 kmymoney/widgets/ktagcontainer.cpp https://invent.kde.org/office/kmymoney/-/commit/62cbaeacb9ceb5a6b580c68cf217df6f6daa968f (In reply to Ralf Habacker from comment #17) > (In reply to Thomas Baumgart from comment #16) > > Git commit 796df584ef0bada68b6c98d75cd8a1af42c4b8ca by Thomas Baumgart. : : > > The above described fix only works for individually selected > > transactions. It is not supported when multiple transactions are > > selected. > > Can this be fixed automatically when loading the file? Unfortunately no. I have not found a rule that allows to automatically modify existing data without possibly causing wrong results. |