Bug 406402

Summary: wi-fi password is not vertically centered
Product: [Plasma] plasmashell Reporter: Patrick Silva <bugseforuns>
Component: Networks widgetAssignee: Jan Grulich <jgrulich>
Status: RESOLVED DUPLICATE    
Severity: normal CC: jgrulich, marcorichetta, nate
Priority: NOR    
Version: master   
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In: 5.15.5
Sentry Crash Report:
Attachments: screenshot
Preliminary patch to fix this issue
screenshot of plasma 5.18.80 on Neon unstable edition

Description Patrick Silva 2019-04-10 12:38:12 UTC
Created attachment 119330 [details]
screenshot

SUMMARY
See the screenshot taken on neon dev unstable. Related to bug 399155


EXPECTED RESULT
password is vertically centered
Comment 1 Jan Grulich 2019-04-10 14:11:37 UTC
It seems to be fixed already in plasma-framework.

*** This bug has been marked as a duplicate of bug 399155 ***
Comment 2 Patrick Silva 2019-04-10 14:20:37 UTC
The problem with sddm and screen locker is already fixed, the problem with plasma-nm persists. Why?
Comment 3 Jan Grulich 2019-04-10 14:24:49 UTC
Created attachment 119332 [details]
Preliminary patch to fix this issue

Can you try this patch?
Comment 4 Patrick Silva 2019-04-10 14:27:37 UTC
Unfortuanately I do not know how to apply patches. :(
Comment 5 Christoph Feck 2019-04-10 20:25:01 UTC
Patrick, applying patches to .qml files is very simple, because it does not require any recompilations. Instructions:

Save patch from comment #3 to /tmp/plasma-nm.diff
In Konsole as root:
    cd /usr/share/plasma/plasmoids/org.kde.plasma.networkmanagement/
    patch -p2 /tmp/plasma-nm.diff
restart plasma session

I don't have plasma-nm installed. If applying the patch failed, you might need to replace -p2 with -p1 or -p3, depending on how deep the folder structure of the installed applet is.
Comment 6 Christoph Feck 2019-04-10 20:27:25 UTC
patch -p2 -i /tmp/plasma-nm.diff
Comment 7 Patrick Silva 2019-04-10 20:56:04 UTC
tested p1, p2 and p3... always the same output:

can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/applet/contents/ui/PasswordField.qml b/applet/contents/ui/PasswordField.qml
|index 425da7d7..f85eec24 100644
|--- a/applet/contents/ui/PasswordField.qml
|+++ b/applet/contents/ui/PasswordField.qml
--------------------------
File to patch:
Comment 8 Nate Graham 2019-04-12 18:00:31 UTC
Well, it's all moot now since the patch was already committed: https://cgit.kde.org/plasma-nm.git/commit/?id=5014b50b719f7ab9837520799b5d9cde2a8b5c46

Please re-open in a week or so if it's not fixed for you.
Comment 9 Marco Richetta 2019-04-30 16:11:36 UTC
(In reply to Nate Graham from comment #8)
> Well, it's all moot now since the patch was already committed:
> https://cgit.kde.org/plasma-nm.git/commit/
> ?id=5014b50b719f7ab9837520799b5d9cde2a8b5c46
> 
> Please re-open in a week or so if it's not fixed for you.

Based on the patch proposed by Cristoph, is there a file where I can look the config applied?

On my current installation:
- KDE neon 5.15
- KDE Plasma Version: 5.15.4
- KDE Frameworks Version: 5.57.0
- Qt Version: 5.12.0

On 
> /usr/share/plasma/plasmoids/org.kde.plasma.networkmanagement/contents.rcc
Line 577, there still is this statement:
> height: implicitHeight; width: units.gridUnit * 15
Comment 10 Nate Graham 2019-04-30 16:42:07 UTC
The fix is in Plasma 5.15.5. Looks like your distro hasn't provided it yet, probably because it hasn't been released. I guess that means you're using KDE Neon User edition rather then developer edition.

You can actually apply the change yourself to the QML file on your local machine to verify that it worked.
Comment 11 Marco Richetta 2019-05-03 13:31:41 UTC
(In reply to Nate Graham from comment #10)
> The fix is in Plasma 5.15.5. Looks like your distro hasn't provided it yet,
> probably because it hasn't been released. I guess that means you're using
> KDE Neon User edition rather then developer edition.

Aha, I missed that. 

> You can actually apply the change yourself to the QML file on your local
> machine to verify that it worked.

I was on the same situation as Patrick on Comment 7, and I put `contents.rcc`(Comment 9) as the file to patch. After restarting the session, it crashed plasmashell everytime.

Sorry for ask but I don't know which file to patch.
Comment 12 Nate Graham 2019-05-03 13:42:07 UTC
Ah ok, I guess you'll have to wait then.
Comment 13 Patrick Silva 2020-01-28 12:41:59 UTC
Created attachment 125482 [details]
screenshot of plasma 5.18.80 on Neon unstable edition

This bug persists on Neon unstable edition with default font settings.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.67.0
Qt Version: 5.13.2
Comment 14 Nate Graham 2020-01-28 16:24:41 UTC

*** This bug has been marked as a duplicate of bug 410810 ***
Comment 15 Ben Cooksley 2024-12-23 18:26:04 UTC
Bulk transfer as requested in T17796