Summary: | AppStream runner reduces KRunner performance and causes calculator runner to not show any results approximately 60% of the time | ||
---|---|---|---|
Product: | [Plasma] krunner | Reporter: | Rakesh <rakesh> |
Component: | calculator | Assignee: | Kai Uwe Broulik <kde> |
Status: | VERIFIED UPSTREAM | ||
Severity: | major | CC: | bugseforuns, cesarg9, f4tmike, kai.stian.olstad, nate, noga.dany, romuluspb |
Priority: | HI | ||
Version: | 5.15.4 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
URL: | https://github.com/ximion/appstream/issues/237 | ||
Latest Commit: | https://github.com/ximion/appstream/commit/0d74990a3f119d1fd96703bd60996b0c43fae733 | Version Fixed In: | AppStream 0.12.7 |
Description
Rakesh
2019-04-10 00:40:49 UTC
I see this intermittently. Seems to trigger more frequently when I add parenthesees. For example "5+(5/6)" triggers no result until I add two equals signs (sometimes I have to them delete one or both). Same here. It's not just calculator but also bookmark and internet search. Operating System: openSUSE Tumbleweed 20190425 KDE-Plasma-Version: 5.15.4 KDE-Frameworks-Version: 5.57.0 Qt-Version: 5.12.2 Kernel-Version: 5.0.9-1-default Art des Betriebssystems: 64-bit Processors: 4 × Intel® Core™ i5-6500T CPU @ 2.50GHz Memory: 15,5 GiB Arbeitsspeicher I also have this problem, but after disabling Software Center in Krunner it's working reliable again. Wow, me too. That's a very useful observation, so thanks for that, In fact turning that off makes KRunner way faster in general, in addition to fixing this bug. Clearly something needs to be fixed in the Software Center runner. If this is a regression in the runner itself, there aren't a whole lot of commits that could have caused it: https://cgit.kde.org/plasma-workspace.git/log/runners/appstream/appstreamrunner.cpp Maybe https://cgit.kde.org/plasma-workspace.git/commit/runners/appstream/appstreamrunner.cpp?id=0ec3f76810b712b99f18ef5f1afa70fe4a3884fd, need to check Interestingly enough I can't reproduce this in KDE Neon Unstable (everything from git master). But I can reproduce it on Manjaro. Investigation by Aleix Pol: $ appstreamcli search "coco" | wc -l 6 $ appstreamcli search "2+2" | wc -l 8953 $ appstreamcli search "" | wc -l 8953 Looks like the culprit here is in the AppStream library which we use for returning matched apps for the AppStream runner when it's enabled. When there are no matches (e.g. because the search term was a mathematical expression), it seems to be returning all items instead of none, which is the cause of the slowdown. Tracking this upstream: https://github.com/ximion/appstream/issues/237 (In reply to Nate Graham from comment #8) > Investigation by Aleix Pol: > > $ appstreamcli search "coco" | wc -l > 6 > $ appstreamcli search "2+2" | wc -l > 8953 > $ appstreamcli search "" | wc -l > 8953 > > Looks like the culprit here is in the AppStream library which we use for > returning matched apps for the AppStream runner when it's enabled. When > there are no matches (e.g. because the search term was a mathematical > expression), it seems to be returning all items instead of none, which is > the cause of the slowdown. > > Tracking this upstream: https://github.com/ximion/appstream/issues/237 Fantastic, thank you for your hard work, Nate! *** Bug 407994 has been marked as a duplicate of this bug. *** Now fixed with https://github.com/ximion/appstream/commit/0d74990a3f119d1fd96703bd60996b0c43fae733 in AppStream 0.12.7 I just updated to AppStream 0.12.7 on Arch Linux and I can confirm that this bug is fixed. \o/ |