Summary: | Add "Close file" button to inview notice about deleted file | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Méven Car <meven29> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kdebugs.81do7, loh.tar, nate |
Priority: | NOR | ||
Version: | 18.04.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/ktexteditor/2a0cf7044f75869644d8d1be92514e01c231b53e | Version Fixed In: | 19.08 |
Description
Méven Car
2019-04-07 16:01:17 UTC
Yes please! hm, to my surprise is such file here not treated as "orphaned" Patch proposal at https://phabricator.kde.org/D20467 Very nice! Git commit 2a0cf7044f75869644d8d1be92514e01c231b53e by Christoph Cullmann, on behalf of Méven Car. Committed on 12/04/2019 at 19:36. Pushed by cullmann into branch 'master'. Allow to close a document whose file was deleted on disk Summary: There is no confirmation window about data lose. Screenshot: {F6766617} FIXED-IN: 19.08 Test Plan: Manually tested Reviewers: cullmann, #kate, #frameworks, dhaumann Reviewed By: cullmann, #kate, dhaumann Subscribers: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel Tags: #kate, #frameworks Differential Revision: https://phabricator.kde.org/D20467 M +6 -0 src/dialogs/katedialogs.cpp M +1 -0 src/dialogs/katedialogs.h M +13 -0 src/document/katedocument.cpp M +1 -0 src/document/katedocument.h https://commits.kde.org/ktexteditor/2a0cf7044f75869644d8d1be92514e01c231b53e I just saw this on the usability blog. I really think this should be changed to "close file" or something more explicit. When I saw the screenshot in the blog, my first thought was that the close button was for the notification -- which I thought was odd, which brought me here. (In reply to Wyatt Childers from comment #6) > I just saw this on the usability blog. I really think this should be changed > to "close file" or something more explicit. When I saw the screenshot in the > blog, my first thought was that the close button was for the notification -- > which I thought was odd, which brought me here. I see your point and I agree, in fact I hesitate when I did the feature. "Close file" would be better than "Close". Review : https://phabricator.kde.org/D20542 Git commit e70ebb44a17d38eca393650477199977f8b29854 by Méven Car. Committed on 15/04/2019 at 07:58. Pushed by meven into branch 'master'. Retitle button "Close" to "Close file" when a file has been removed on disk Summary: CCBUG: 406305 Reviewers: #ktexteditor, ngraham, cullmann Reviewed By: #ktexteditor, ngraham, cullmann Subscribers: cullmann, kossebau, kwrite-devel, kde-frameworks-devel Tags: #kate, #frameworks Differential Revision: https://phabricator.kde.org/D20542 M +1 -1 src/dialogs/katedialogs.cpp https://commits.kde.org/ktexteditor/e70ebb44a17d38eca393650477199977f8b29854 |