| Summary: | kblocks does not play the theme sounds | ||
|---|---|---|---|
| Product: | [Applications] kblocks | Reporter: | José JORGE <lists.jjorge> |
| Component: | general | Assignee: | Zhongjie Cai <squall.leonhart.cai> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, kde-games-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Mageia RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/games/kblocks/commit/a5d0a2c8c6f67436376a51ea60b5e654dac05ba7 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
José JORGE
2019-04-06 06:25:46 UTC
Yeah by looking at the existing themes it seems like at some point the sound files where customizable (or at least that was the plan), but looking at the code it isn't, it just plays the three hardcoded files in the code. (In reply to Albert Astals Cid from comment #1) > Yeah by looking at the existing themes it seems like at some point the sound > files where customizable (or at least that was the plan), but looking at the > code it isn't, it just plays the three hardcoded files in the code. Thanks for the bootstrap : I did that crazy thing which is trying to contribute my first code to KDE, while I use it since 1998 ;-) D21472 and D21477 in Phabricator waiting to be reviewed. Git commit 35ae7d63e71db4e2d824081d7e05c1a484755be8 by Albert Astals Cid, on behalf of José JORGE [zezinho]. Committed on 08/06/2019 at 22:06. Pushed by aacid into branch 'master'. Use the theme file defined sounds if they are declared. Summary: The theme files define themed sounds, but the code does not use them. This make it work, tested with Europe theme downloaded through KnewStuff. Reviewers: #kde_games, aacid Subscribers: aspotashev, aacid, kde-games-devel Differential Revision: https://phabricator.kde.org/D21477 A +3 -0 .arcconfig M +1 -1 CMakeLists.txt M +3 -1 KBlocksScene.cpp M +42 -8 KBlocksSound.cpp M +10 -1 KBlocksSound.h https://commits.kde.org/kblocks/35ae7d63e71db4e2d824081d7e05c1a484755be8 Git commit a5d0a2c8c6f67436376a51ea60b5e654dac05ba7 by Albert Astals Cid, on behalf of José JORGE [zezinho]. Committed on 08/06/2019 at 21:58. Pushed by aacid into branch 'arcpatch-D21477'. Use the theme file defined sounds if they are declared. Summary: The theme files define themed sounds, but the code does not use them. This make it work, tested with Europe theme downloaded through KnewStuff. Reviewers: #kde_games, aacid Subscribers: aspotashev, aacid, kde-games-devel Differential Revision: https://phabricator.kde.org/D21477 A +3 -0 .arcconfig M +1 -1 CMakeLists.txt M +3 -1 KBlocksScene.cpp M +42 -8 KBlocksSound.cpp M +10 -1 KBlocksSound.h https://invent.kde.org/games/kblocks/commit/a5d0a2c8c6f67436376a51ea60b5e654dac05ba7 |