| Summary: | Crash when applying split alpha to layers | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | Layers/Vector | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | freebox64, halla |
| Priority: | NOR | Keywords: | regression, triaged |
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/krita/38175ae5b1efddcecf6f0699544884e5278a7c3f | Version Fixed In: | |
| Attachments: | valgrind memcheck log of the crash | ||
|
Description
acc4commissions
2019-04-05 05:16:42 UTC
I can confirm this issue, it also happens in master: Thread 1 (Thread 0x7fcf33284840 (LWP 31458)): [KCrash Handler] #6 0x0000000000000000 in ?? () #7 0x00007fcef050945b in KisSharedPtr<KisPaintDevice>::deref (sp=0x7ffef3764868, t=<optimized out>) at /home/boud/dev/krita/libs/global/kis_shared_ptr.h:211 #8 KisSharedPtr<KisPaintDevice>::deref (this=0x7ffef3764868) at /home/boud/dev/krita/libs/global/kis_shared_ptr.h:225 #9 KisSharedPtr<KisPaintDevice>::~KisSharedPtr (this=0x7ffef3764868, __in_chrg=<optimized out>) at /home/boud/dev/krita/libs/global/kis_shared_ptr.h:109 #10 KisColorSelectorContainer::reactOnLayerChange (this=0x55b10f5a7680) at /home/boud/dev/krita/plugins/dockers/advancedcolorselector/kis_color_selector_container.cpp:214 #11 0x00007fcf2e811e25 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #12 0x00007fcf3201ce05 in KisNodeManager::sigLayerActivated (this=this@entry=0x55b10d43b940, _t1=...) at /home/boud/dev/b-krita/libs/ui/kritaui_autogen/EWIEGA46WW/moc_kis_node_manager.cpp:456 #13 0x00007fcf3201c50e in KisNodeManager::qt_static_metacall (_o=0x55b10d43b940, _c=<optimized out>, _id=<optimized out>, _a=0x7ffef3764be0) at /home/boud/dev/b-krita/libs/ui/kritaui_autogen/EWIEGA46WW/moc_kis_node_manager.cpp:309 #14 0x00007fcf2e811e25 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #15 0x00007fcf3201bb32 in KisLayerManager::sigLayerActivated (this=this@entry=0x55b10d2cf5c0, _t1=...) at /home/boud/dev/b-krita/libs/ui/kritaui_autogen/EWIEGA46WW/moc_kis_layer_manager.cpp:340 #16 0x00007fcf31c105d0 in KisLayerManager::activateLayer (this=this@entry=0x55b10d2cf5c0, layer=...) at /home/boud/dev/krita/libs/ui/kis_layer_manager.cc:151 #17 0x00007fcf31c3a13c in KisNodeManager::Private::activateNodeImpl (this=0x55b10d2cf5a0, node=...) at /home/boud/dev/krita/libs/ui/kis_node_manager.cpp:191 #18 0x00007fcf31c3af53 in KisNodeManager::slotSomethingActivatedNodeImpl (this=this@entry=0x55b10d43b940, node=...) at /home/boud/dev/krita/libs/ui/kis_node_manager.cpp:656 #19 0x00007fcf31c3b242 in KisNodeManager::slotNonUiActivatedNode (this=this@entry=0x55b10d43b940, node=...) at /home/boud/dev/krita/libs/ui/kis_node_manager.cpp:679 #20 0x00007fcf3201c572 in KisNodeManager::qt_static_metacall (_o=0x55b10d43b940, _c=<optimized out>, _id=<optimized out>, _a=0x7ffef3764eb0) at /home/boud/dev/b-krita/libs/ui/kritaui_autogen/EWIEGA46WW/moc_kis_node_manager.cpp:312 #21 0x00007fcf2e811e25 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #22 0x00007fcf32014dd5 in KisDummiesFacadeBase::sigActivateNode (this=this@entry=0x55b115600790, _t1=...) at /home/boud/dev/b-krita/libs/ui/kritaui_autogen/QUY67KCZCL/moc_kis_dummies_facade_base.cpp:304 #23 0x00007fcf31b5d57d in KisDummiesFacadeBase::slotNodeActivationRequested (this=this@entry=0x55b115600790, node=...) at /home/boud/dev/krita/libs/ui/flake/kis_dummies_facade_base.cpp:120 #24 0x00007fcf320147b3 in KisDummiesFacadeBase::qt_static_metacall (_o=0x55b115600790, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /home/boud/dev/b-krita/libs/ui/kritaui_autogen/QUY67KCZCL/moc_kis_dummies_facade_base.cpp:144 #25 0x00007fcf2e811e25 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #26 0x00007fcf30a04b65 in KisImage::sigNodeAddedAsync (this=<optimized out>, _t1=...) at /home/boud/dev/b-krita/libs/image/kritaimage_autogen/EWIEGA46WW/moc_kis_image.cpp:725 #27 0x00007fcf30a07266 in KisImage::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=0x7ffef37652a0) at /home/boud/dev/b-krita/libs/image/kritaimage_autogen/EWIEGA46WW/moc_kis_image.cpp:318 #28 0x00007fcf2e811e25 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #29 0x00007fcf30a052c5 in KisImageSignalRouter::sigNodeAddedAsync (this=this@entry=0x55b1156b0578, _t1=...) at /home/boud/dev/b-krita/libs/image/kritaimage_autogen/EWIEGA46WW/moc_kis_image_signal_router.cpp:384 #30 0x00007fcf3082c66c in KisImageSignalRouter::emitNodeHasBeenAdded (this=0x55b1156b0578, parent=<optimized out>, index=<optimized out>) at /home/boud/dev/krita/libs/image/kis_image_signal_router.cpp:113 #31 0x00007fcf308aa131 in KisNode::add (this=0x55b115754e40, newNode=..., aboveThis=...) at /home/boud/dev/krita/libs/image/kis_node.cpp:508 #32 0x00007fcf308ad63a in KisNodeFacade::addNode (this=<optimized out>, node=..., parent=..., aboveThis=...) at /home/boud/dev/krita/libs/image/kis_node_facade.cpp:121 #33 0x00007fcf306c87a5 in KisImageLayerAddCommand::redo (this=0x55b118c64a40) at /home/boud/dev/krita/libs/image/commands/kis_image_layer_add_command.cpp:65 #34 0x00007fcf2b11b9c5 in KUndo2Command::redoMergedCommands (this=0x55b118c64a40) at /home/boud/dev/krita/libs/command/kundo2stack.cpp:398 #35 0x00007fcf2b11bbe8 in KUndo2QStack::push (this=0x55b11560d530, cmd=<optimized out>) at /home/boud/dev/krita/libs/command/kundo2stack.cpp:711 #36 0x00007fcf3093f81a in KisLegacyUndoAdapter::addCommand (this=this@entry=0x55b1156b0500, command=command@entry=0x55b118c64a40) at /home/boud/dev/krita/libs/image/kis_legacy_undo_adapter.cpp:47 #37 0x00007fcf31c2c255 in KisNodeCommandsAdapter::addNode (this=<optimized out>, node=..., parent=..., aboveThis=..., doRedoUpdates=<optimized out>, doUndoUpdates=<optimized out>) at /home/boud/dev/krita/libs/ui/kis_node_commands_adapter.cpp:89 #38 0x00007fcf31c1d1a1 in KisMaskManager::createMaskCommon (this=this@entry=0x55b10d2cf630, mask=..., activeNode=..., copyFrom=..., macroName=..., nodeType=..., nodeName=..., suppressSelection=false, avoidActiveNode=false, updateImage=true) at /home/boud/dev/krita/libs/ui/kis_mask_manager.cc:184 #39 0x00007fcf31c1dbd2 in KisMaskManager::createTransparencyMask (this=0x55b10d2cf630, activeNode=..., copyFrom=..., convertActiveNode=convertActiveNode@entry=false) at /home/boud/dev/krita/libs/ui/kis_mask_manager.cc:218 #40 0x00007fcf31c38246 in KisNodeManager::createNode (this=this@entry=0x55b10d43b940, nodeType=..., quiet=quiet@entry=false, copyFrom=...) at /home/boud/dev/krita/libs/ui/kis_node_manager.cpp:568 #41 0x00007fcf31c3a776 in KisNodeManager::slotSplitAlphaIntoMask (this=0x55b10d43b940) at /home/boud/dev/krita/libs/ui/kis_node_manager.cpp:1200 #42 0x00007fcf3201ca78 in KisNodeManager::qt_static_metacall (_o=0x55b10d43b940, _c=<optimized out>, _id=<optimized out>, _a=0x7ffef3766200) at /home/boud/dev/b-krita/libs/ui/kritaui_autogen/EWIEGA46WW/moc_kis_node_manager.cpp:350 #43 0x00007fcf2e811e25 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #44 0x00007fcf2f5d20f2 in QAction::triggered(bool) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #45 0x00007fcf2f5d470c in QAction::activate(QAction::ActionEvent) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #46 0x00007fcf2f7493ac in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #47 0x00007fcf2f75091b in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #48 0x00007fcf2f751793 in QMenu::mouseReleaseEvent(QMouseEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #49 0x00007fcf2f618838 in QWidget::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #50 0x00007fcf2f753abb in QMenu::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #51 0x00007fcf2f5d883c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #52 0x00007fcf2f5e0ca8 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #53 0x00007fcf31f045a7 in KisApplication::notify (this=<optimized out>, receiver=0x55b115a17190, event=0x7ffef3766950) at /home/boud/dev/krita/libs/ui/KisApplication.cpp:639 #54 0x00007fcf2e7e2328 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #55 0x00007fcf2f5df29f in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #56 0x00007fcf2f63379d in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #57 0x00007fcf2f63634a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #58 0x00007fcf2f5d883c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #59 0x00007fcf2f5dfdd0 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #60 0x00007fcf31f045a7 in KisApplication::notify (this=<optimized out>, receiver=0x7fcf000075c0, event=0x7ffef3766e50) at /home/boud/dev/krita/libs/ui/KisApplication.cpp:639 #61 0x00007fcf2e7e2328 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #62 0x00007fcf2edaa52b in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5 #63 0x00007fcf2edab695 in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5 #64 0x00007fcf2ed8414b in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5 #65 0x00007fcf19e1930a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5 #66 0x00007fcf25eaf387 in g_main_context_dispatch () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #67 0x00007fcf25eaf5c0 in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #68 0x00007fcf25eaf64c in g_main_context_iteration () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #69 0x00007fcf2e83f13f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #70 0x00007fcf2e7e064a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #71 0x00007fcf2f74e600 in QMenu::exec(QPoint const&, QAction*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #72 0x00007fceef3eed81 in LayerBox::slotContextMenuRequested (this=<optimized out>, pos=..., index=...) at /home/boud/dev/krita/plugins/dockers/layerdocker/LayerBox.cpp:683 #73 0x00007fceef3ef41d in LayerBox::qt_static_metacall (_o=0x55b10d2e7e70, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /home/boud/dev/b-krita/plugins/dockers/layerdocker/kritalayerdocker_autogen/include/moc_LayerBox.cpp:228 #74 0x00007fcf2e811e25 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #75 0x00007fceef404ae7 in NodeView::contextMenuRequested (this=this@entry=0x55b10f1ffd80, _t1=..., _t2=...) at /home/boud/dev/b-krita/plugins/dockers/layerdocker/kritalayerdocker_autogen/EWIEGA46WW/moc_NodeView.cpp:224 #76 0x00007fceef402b2a in NodeView::showContextMenu (index=..., globalPos=..., this=<optimized out>) at /home/boud/dev/krita/plugins/dockers/layerdocker/NodeView.cpp:318 #77 NodeView::contextMenuEvent (this=0x55b10f1ffd80, e=0x7ffef3767d30) at /home/boud/dev/krita/plugins/dockers/layerdocker/NodeView.cpp:313 #78 0x00007fcf2f619614 in QWidget::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #79 0x00007fcf2f6bad1e in QFrame::event(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #80 0x00007fcf2f831c73 in QAbstractItemView::viewportEvent(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #81 0x00007fcf2f89b80c in QTreeView::viewportEvent(QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #82 0x00007fceef401f3b in NodeView::viewportEvent (this=0x55b10f1ffd80, e=0x7ffef3767d30) at /home/boud/dev/krita/plugins/dockers/layerdocker/NodeView.cpp:304 #83 0x00007fcf2e7e20ad in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #84 0x00007fcf2f5d8815 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #85 0x00007fcf2f5e02e7 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #86 0x00007fcf31f045a7 in KisApplication::notify (this=<optimized out>, receiver=0x55b10f200490, event=0x7ffef3767d30) at /home/boud/dev/krita/libs/ui/KisApplication.cpp:639 #87 0x00007fcf2e7e2328 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #88 0x00007fcf2f633bc8 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #89 0x00007fcf2f63634a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #90 0x00007fcf2f5d883c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #91 0x00007fcf2f5dfdd0 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5 #92 0x00007fcf31f045a7 in KisApplication::notify (this=<optimized out>, receiver=0x55b10d41da20, event=0x7ffef3768270) at /home/boud/dev/krita/libs/ui/KisApplication.cpp:639 #93 0x00007fcf2e7e2328 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #94 0x00007fcf2edaa52b in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5 #95 0x00007fcf2edab695 in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5 #96 0x00007fcf2ed8414b in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5 #97 0x00007fcf19e1930a in ?? () from /usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5 #98 0x00007fcf25eaf387 in g_main_context_dispatch () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #99 0x00007fcf25eaf5c0 in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #100 0x00007fcf25eaf64c in g_main_context_iteration () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #101 0x00007fcf2e83f13f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #102 0x00007fcf2e7e064a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #103 0x00007fcf2e7e9800 in QCoreApplication::exec() () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #104 0x000055b100da8191 in main (argc=<optimized out>, argv=0x7ffef3768928) at /home/boud/dev/krita/krita/main.cc:495 I cannot reproduce with 4.1; are you sure you're using 4.1 and not a nightly build? The git sha1 you gave doesn't seem to exist. (In reply to Boudewijn Rempt from comment #2) > I cannot reproduce with 4.1; are you sure you're using 4.1 and not a nightly > build? The git sha1 you gave doesn't seem to exist. Sorry. Yes, it's a nightly build. I submitted the report directly via application's help > Report Bug menu and didn't check the version setting it gave me. Right, so no wonder I couldn't reproduce :-) Created attachment 119256 [details]
valgrind memcheck log of the crash
Git commit 38175ae5b1efddcecf6f0699544884e5278a7c3f by Dmitry Kazakov. Committed on 08/04/2019 at 08:56. Pushed by dkazakov into branch 'master'. Fix crash in Split Alpha convertTo() cannot be called from the ctor, because it creates chared pointers to 'this', which causes early death of the object. M +17 -12 libs/image/kis_paint_device.cc M +2 -0 libs/image/kis_paint_device.h M +6 -3 libs/image/kis_pixel_selection.cpp https://commits.kde.org/krita/38175ae5b1efddcecf6f0699544884e5278a7c3f *** Bug 399751 has been marked as a duplicate of this bug. *** *** Bug 399749 has been marked as a duplicate of this bug. *** |