Summary: | Ruler cannot be set to anything but pixels | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Gremriel <gremriel> |
Component: | Usability | Assignee: | Tiar <tamtamy.tymona> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | griffinvalley, halla, tamtamy.tymona |
Priority: | NOR | Keywords: | triaged |
Version: | nightly build (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://commits.kde.org/krita/4636c73d5c5b2b13a8f1b08b49967b5decff2754 | Version Fixed In: | |
Sentry Crash Report: |
Description
Gremriel
2019-04-03 12:38:17 UTC
I can confirm. These values are enough to do a git bisect in any case. The gap is only 2 weeks, btw (february 20 - March 5) Eek, for some reason, those sha1-like numbers aren't actually commit sha1's... So we'd also need to have the git version as shown in the about box for both versions. Do you still have them around? It's between 703cbfbfae56a3a2b9518f94e882e4868023794d and be454f91ec08ecdd141db343477210fbb3981457 Version that does not have the issue: git be454f9 (feb 20) Version with issue: git 703cbfb (march 5) These are the numbers from the About Krita window, but they look the same as the first digits I posted in the first report. I would be vastly surprised if this didn't have something to do with: commit 9d5baac8ad84d838b5b326eef130bb739411c21d Author: Agata Cacko <tamtamy.tymona@gmail.com> Date: Tue Mar 5 11:27:49 2019 +0100 Refactor KoUnit Tiar, could you take a look? Git commit 4636c73d5c5b2b13a8f1b08b49967b5decff2754 by Agata Cacko. Committed on 08/04/2019 at 09:45. Pushed by tymond into branch 'master'. Fix rulers showing pixels no matter the unit Before this commit, when you selected the unit for a ruler, it stayed as pixels. This patch changes the behaviour so the ruler has correct unit now. M +1 -1 libs/ui/kis_mirror_manager.cpp https://commits.kde.org/krita/4636c73d5c5b2b13a8f1b08b49967b5decff2754 |