Bug 406181

Summary: Ruler cannot be set to anything but pixels
Product: [Applications] krita Reporter: Gremriel <gremriel>
Component: UsabilityAssignee: Tiar <tamtamy.tymona>
Severity: normal CC: griffinvalley, halla, tamtamy.tymona
Priority: NOR Keywords: triaged
Version: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Gremriel 2019-04-03 12:38:17 UTC
When right-clicking on the ruler to set a different unit of measurement, the ruler still displays in pixels.

Windows: 10 64-bit

This is present since krita-nightly-x64-v4.2.0-prealpha-338-g703cbfbfae (march 5).
The last version that did not have this issue was krita-nightly-x64-v4.2.0-prealpha-216-gbe454f91ec, but there's a 3 week gap between these nightlies, so, I can't pin-point exactly when it started.
Comment 1 wolthera 2019-04-03 12:40:22 UTC
I can confirm. These values are enough to do a git bisect in any case.
Comment 2 Gremriel 2019-04-03 13:02:16 UTC
The gap is only 2 weeks, btw (february 20 - March 5)
Comment 3 Halla Rempt 2019-04-03 14:44:41 UTC
Eek, for some reason, those sha1-like numbers aren't actually commit sha1's... So we'd also need to have the git version as shown in the about box for both versions. Do you still have them around?
Comment 4 wolthera 2019-04-03 14:51:27 UTC
It's between



Comment 5 Gremriel 2019-04-03 14:54:38 UTC
Version that does not have the issue: git be454f9 (feb 20)

Version with issue: git 703cbfb (march 5)

These are the numbers from the About Krita window, but they look the same as the first digits I posted in the first report.
Comment 6 Halla Rempt 2019-04-03 14:55:03 UTC
I would be vastly surprised if this didn't have something to do with: 

commit 9d5baac8ad84d838b5b326eef130bb739411c21d
Author: Agata Cacko <tamtamy.tymona@gmail.com>
Date:   Tue Mar 5 11:27:49 2019 +0100

    Refactor KoUnit

Tiar, could you take a look?
Comment 7 Tiar 2019-04-08 09:46:15 UTC
Git commit 4636c73d5c5b2b13a8f1b08b49967b5decff2754 by Agata Cacko.
Committed on 08/04/2019 at 09:45.
Pushed by tymond into branch 'master'.

Fix rulers showing pixels no matter the unit

Before this commit, when you selected the unit for a ruler,
it stayed as pixels. This patch changes the behaviour
so the ruler has correct unit now.

M  +1    -1    libs/ui/kis_mirror_manager.cpp