Bug 406179

Summary: KStars Lite + EQMod interrupt tracking when sync command is executed
Product: [Applications] kstars Reporter: sebastian
Component: generalAssignee: Jasem Mutlaq <mutlaqja>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Android   
OS: Android 9.x   
Latest Commit: https://commits.kde.org/kstars/5577dc1c6ec0696d975f8ed4cc639ef970bf28ef Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Patch removing aborts from slew and sync

Description sebastian 2019-04-03 11:26:31 UTC 
SUMMARY
When sync command is issued on KStars Lite, tracking is stopped and "[WARNING] Syncs are allowed only when Tracking " is shown. Sync point is not added to alignment model.

SETUP
RPi with INDI and EQMod connected to Skywatcher mount. Android phone connected via Wifi.

STEPS TO REPRODUCE
1. Connect KStars Lite to working INDI Server with EQMod (also works with simulator)
2. Start tracking in INDI
3. Select any object in KStars Lite and exec EQMod/Sync

OBSERVED RESULT:
Tracking is stopped
Warning is shown: "[WARNING] Syncs are allowed only when Tracking "
Point is not added to the model

EXPECTED RESULT
Tracking is not stopped.
Point is added to align model.


ADDITIONAL INFORMATION
I started checking the issue and I think that I found the bug (I cannot compile and check by myself). In inditelescopelite.cpp there is abort() called at the beginning of bool TelescopeLite::sync(SkyPoint *ScopeTarget). In contrast this line is not present in inditelescope.cpp (and Desktop version of KStars works correctly).
Comment 1 sebastian 2019-04-03 11:27:21 UTC 
BTW this issue was reported 2y ago here: https://indilib.org/forum/embedded-indi/1993-kstars-lite-sync-doesn-t-work.html
Comment 2 sebastian 2019-04-08 21:24:13 UTC 
Created attachment 119303 [details]
Patch removing aborts from slew and sync
Comment 3 Jasem Mutlaq 2019-04-09 05:29:36 UTC 
Git commit 5577dc1c6ec0696d975f8ed4cc639ef970bf28ef by Jasem Mutlaq.
Committed on 09/04/2019 at 05:28.
Pushed by mutlaqja into branch 'master'.

Fix slew and sync in KStars Lite. Patch by Sebastian.

M  +0    -2    kstars/indi/inditelescopelite.cpp

https://commits.kde.org/kstars/5577dc1c6ec0696d975f8ed4cc639ef970bf28ef