Summary: | Allow people to change the name used for their reviews | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | 4wy78uwh, aleixpol |
Priority: | HI | ||
Version: | 5.14.5 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/discover/commit/ee3d6e9c912d901174a44fe96136583086cd6932 | Version Fixed In: | 5.26 |
Sentry Crash Report: |
Description
Nate Graham
2019-03-27 18:55:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/362 Git commit ee3d6e9c912d901174a44fe96136583086cd6932 by Aleix Pol Gonzalez, on behalf of Bernardo Gomes Negri. Committed on 31/08/2022 at 16:19. Pushed by apol into branch 'master'. Add option to change name in review dialog. I only needed to change significantly the ODRS backend, since KNS appears to handle user names separately. M +7 -4 discover/qml/ReviewDialog.qml M +1 -1 discover/qml/ReviewsPage.qml M +30 -0 libdiscover/ReviewsBackend/AbstractReviewsBackend.cpp M +16 -5 libdiscover/ReviewsBackend/AbstractReviewsBackend.h M +2 -2 libdiscover/appstream/OdrsReviewsBackend.cpp M +8 -2 libdiscover/appstream/OdrsReviewsBackend.h M +2 -2 libdiscover/backends/DummyBackend/DummyReviewsBackend.cpp M +4 -1 libdiscover/backends/DummyBackend/DummyReviewsBackend.h M +1 -1 libdiscover/backends/KNSBackend/KNSReviews.cpp M +4 -2 libdiscover/backends/KNSBackend/KNSReviews.h https://invent.kde.org/plasma/discover/commit/ee3d6e9c912d901174a44fe96136583086cd6932 Is this still possible? I don't see any option to do so. |