| Summary: | Key modifier names are not translated while setting a shortcut | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kxmlgui | Reporter: | David Redondo <kde> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid |
| Priority: | NOR | ||
| Version First Reported In: | 5.56.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kxmlgui/1b49ea4d3154630f79b604a191265cff687c18ad | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Shift being displayed instead of Umschalt | ||
The translated key names come from https://cgit.kde.org/kwindowsystem.git/tree/src/kkeyserver.cpp Someone familiar with Qt translations would be needed to investigate. The code seems to cache the translations. Maybe that's the cause for the issue. Having a look (well almost have a patch) Git commit 1b49ea4d3154630f79b604a191265cff687c18ad by Albert Astals Cid. Committed on 16/04/2019 at 22:07. Pushed by aacid into branch 'master'. KKeySequenceWidget: Don't show English strings to the user Summary: KKeyServer::modToStringUser is only for english texts Reviewers: apol Reviewed By: apol Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D20614 M +11 -0 autotests/kxmlgui_unittest.cpp M +1 -0 autotests/kxmlgui_unittest.h M +7 -7 src/kkeysequencewidget.cpp https://commits.kde.org/kxmlgui/1b49ea4d3154630f79b604a191265cff687c18ad |
Created attachment 119075 [details] Shift being displayed instead of Umschalt SUMMARY While setting a shortcut the modifier is not correctly translated while holding it down. It is correctly translated after setting the shortcut. STEPS TO REPRODUCE 1. Change a shortcut. 2. Hold down shift or ctrl OBSERVED RESULT "Shift + ..." / "Ctrl + ..." is displayed EXPECTED RESULT Shift and Ctrl should be translated (in my case Umschalt and Strg) Frameworks version: 5.56