| Summary: | kdenlive fails to build with external rttr | ||
|---|---|---|---|
| Product: | [Applications] kdenlive | Reporter: | Antonio Rojas <arojas> |
| Component: | Setup & Installation | Assignee: | Vincent PINON <vpinon> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asturm, christophe, fritzibaby, julius.kuenzel |
| Priority: | NOR | Flags: | fritzibaby:
Brainstorm+
|
| Version First Reported In: | git-master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | b48d76d898419ed36c8bdb16253f1f0c6c53d210 | Version Fixed In: | 19.04.0 |
| Sentry Crash Report: | |||
|
Description
Antonio Rojas
2019-03-24 10:05:46 UTC
From RTTR 0.9.6 CMakeFiles, it appeared that Core_lib target is for static lib, while Core is for dynamic lib. Did you configure rttr to generate static lib too? It is true that our RTTR integration is for now not yet very packaging-friendly, we are OK to improve the situation... From your side, would switching to dynamic linking be sufficient? (In reply to Vincent PINON from comment #1) > From RTTR 0.9.6 CMakeFiles, it appeared that Core_lib target is for static > lib, while Core is for dynamic lib. Did you configure rttr to generate > static lib too? No, it's our distro policy not to ship static libraries > It is true that our RTTR integration is for now not yet very > packaging-friendly, we are OK to improve the situation... > From your side, would switching to dynamic linking be sufficient? Not sure what you mean here... switching what to dynamic linking? > From your side, would switching to dynamic linking be sufficient?
For linux distributions, yes, for Windows you would get the opposite issue, I guess.
something like that should address the problem:
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 4d196d18e..b68f31c2c 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -139,8 +139,12 @@ target_link_libraries(kdenliveLib
${MLTPP_LIBRARIES}
${CMAKE_DL_LIBS}
${CMAKE_THREAD_LIBS_INIT}
- kiss_fft
- RTTR::Core_Lib)
+ kiss_fft)
+if(TARGET RTTR::Core)
+ target_link_libraries(kdenliveLib RTTR::Core)
+else()
+ target_link_libraries(kdenliveLib RTTR::Core_Lib)
+endif()
if(BUILD_COVERAGE)
target_link_libraries(kdenliveLib gcov)
Sorry, I didn't notice the typo in Luca's MR. https://invent.kde.org/kde/kdenlive/merge_requests/31 fixes the issue. Seems to be fixed with https://invent.kde.org/multimedia/kdenlive/-/merge_requests/29 (???) |