Bug 405749

Summary:	Potential issue with holiday listing for Poland
Product:	[Frameworks and Libraries] frameworks-kholidays	Reporter:	Kenny D <kenny>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	junior-jobs
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	https://cgit.kde.org/kholidays.git/commit/?id=d1f6062a818cfab2adef6a3219ab8b9154b8c78a	Version Fixed In:	5.57
Sentry Crash Report:

Description Kenny D 2019-03-22 09:59:55 UTC

This bug was reported via email through an anonymiser service to KDE Press Contacts:

It came to our attention, that Calendar Holiday Plugin for KDE,
that should contain holidays for Poland is written extremely
sloppy and contains extreme and excessive number of days that are not holidays
(they are not state holidays and are not days off- therefore
calendar is useless and we cannot see which days are off and
state celebrated by our Great Nation), but also the national
holidays are written very sloppy and the names are not the official
names of the holidays (eg. &#346;wi&#281;to Konstytucji- there's no such
holiday in Poland its Konstytucji 3-ego Maja! its not "a holiday
of some constitution", holiday has a specific name! 
Moreover its interwined with some non holiday "equinox", "grampa" and "beer" days.

Comment 1 Christophe Marin 2019-03-22 10:27:12 UTC

After a quick look, the holiday file for Poland wasn't touched since 2015.

It contains categories however. The holidays belong to one of these: public, religious, cultural and civil.

Comment 2 Kenny D 2019-03-22 11:36:42 UTC

(In reply to Christophe Giboudeaux from comment #1)
> After a quick look, the holiday file for Poland wasn't touched since 2015.
> 
> It contains categories however. The holidays belong to one of these: public,
> religious, cultural and civil.

Thanks for having a look

Comment 3 Christophe Marin 2019-03-22 13:34:04 UTC

Strange the bug wasn't closed automatically.

https://cgit.kde.org/kholidays.git/commit/?id=d1f6062a818cfab2adef6a3219ab8b9154b8c78a fixes the wrong name for the Constitution day, sorts the categories and I added english comments if anyone needs to touch the file in the future.

I also tried loading the polish days in korganizer, the non-working days (categorized 'public') have a different color.

Without a proper way to contact the mail author, that's the best we can do.

Comment 4 Kenny D 2019-03-22 13:45:09 UTC

(In reply to Christophe Giboudeaux from comment #3)
> Strange the bug wasn't closed automatically.
> 
> https://cgit.kde.org/kholidays.git/commit/
> ?id=d1f6062a818cfab2adef6a3219ab8b9154b8c78a fixes the wrong name for the
> Constitution day, sorts the categories and I added english comments if
> anyone needs to touch the file in the future.
> 
> I also tried loading the polish days in korganizer, the non-working days
> (categorized 'public') have a different color.
> 
> Without a proper way to contact the mail author, that's the best we can do.

Thanks