Bug 405540

Summary:	Brush Outline are white in Krita nightly build
Product:	[Applications] krita	Reporter:	reptillia39
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alvin, manuel.snudl.zeidler, postrowski5
Priority:	NOR
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/krita/5699be5ac06b3f25f4616947a3a4faf03956e2d1	Version Fixed In:
Sentry Crash Report:
Attachments:	See-through brush outline

Description reptillia39 2019-03-16 20:41:32 UTC

SUMMARY
When I tried to paint, it took me a while to notice that I actually don't have any idea on where I am painting. The source? The fact that the brush outline is now white on a white canvas. It was not like this before.

STEPS TO REPRODUCE
1. Just paint.

OBSERVED RESULT
White brush outline on white canvas. It shows up on black fills, but not on white fills.

EXPECTED RESULT
I am able to see where I am going to paint without having to guess blindly.

SOFTWARE/OS VERSIONS
Windows: Microsoft Windows 10 Home Version 10.0.17134 Build 17134
Software - Krita 4.2.0-pre-alpha (git 0492ac7) - Source from Jenkins
Graphic Card - NVIDIA Quadro K4200
OpenGL Enabled


ADDITIONAL INFORMATION

Comment 1 reptillia39 2019-03-16 22:35:13 UTC

Found out something, when I reverted back to e6f675, the brush outline are completely gone. Didn't happened before I installed the latest Jenkins beta as of this date or the reported version. 

Also, tablet support are broken in the latest build, but not sure if I should report that seeing as QT support is experimental. Now, they act like a mouse would, well, mostly.

Comment 2 Alvin Wong 2019-03-25 13:58:54 UTC

This doesn't happen with ANGLE, btw.

Comment 3 M 2019-03-25 14:52:16 UTC

Created attachment 119024 [details]
See-through brush outline

I added a screenshot showing my brush outline is see-through.

System info is the same as what I commented here:
https://bugs.kde.org/show_bug.cgi?id=404935

Comment 4 Dmitry Kazakov 2019-03-26 10:26:35 UTC

Git commit e1d56f30d513b7f08124ba8eea300b76ce4b3e7e by Dmitry Kazakov.
Committed on 26/03/2019 at 10:26.
Pushed by dkazakov into branch 'master'.

Make sure Krita doesn't request alpha-enabled texture buffers

glBlendFunc doesn't support correct alpha blending (alpha channel
value should be calculated separately), so we must ensure that the
calculated alpha value is just dropped entirely.
Related: bug 404935

M  +3    -3    libs/ui/opengl/KisOpenGLModeProber.cpp
M  +4    -0    libs/ui/opengl/kis_opengl_canvas2.cpp

https://commits.kde.org/krita/e1d56f30d513b7f08124ba8eea300b76ce4b3e7e

Comment 5 Dmitry Kazakov 2019-03-26 15:51:10 UTC

Git commit 5699be5ac06b3f25f4616947a3a4faf03956e2d1 by Dmitry Kazakov.
Committed on 26/03/2019 at 15:50.
Pushed by dkazakov into branch 'master'.

Fix semi-transparent bug properly on Windows
Related: bug 404935

M  +3    -3    libs/ui/opengl/KisOpenGLModeProber.cpp
M  +12   -1    libs/ui/opengl/kis_opengl_canvas2.cpp

https://commits.kde.org/krita/5699be5ac06b3f25f4616947a3a4faf03956e2d1

Comment 6 Dmitry Kazakov 2019-03-27 13:56:25 UTC

*** Bug 405913 has been marked as a duplicate of this bug. ***

Comment 7 Dmitry Kazakov 2019-04-02 13:07:09 UTC

*** Bug 405725 has been marked as a duplicate of this bug. ***