Bug 405522

Summary:	Third party icons are not loaded even if available in QIcon fallbackSearchPaths
Product:	[Frameworks and Libraries] frameworks-kiconthemes	Reporter:	Rinigus <rinigus.git>
Component:	general	Assignee:	Christoph Feck <cfeck>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fabstz-it, kde, kdelibs-bugs-null, rinigus.git
Priority:	NOR
Version First Reported In:	5.56.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kiconthemes/commit/19d2ec41fef106de5d60adacbb43f22a90ff6c1b	Version Fixed/Implemented In:
Sentry Crash Report:

Description Rinigus 2019-03-16 13:36:50 UTC

SUMMARY

When using QT_QUICK_CONTROLS_STYLE=org.kde.desktop, Kirigami global drawer and buttons fail to load icons specified by name and available in the fallback path. For example, if an application has some specific icons, its impossible to load them as a part of global drawer (menu action) or as an action button on toolbar. At the same time, the same icon loads fine using IconImage of QML (from qc2 private). 

STEPS TO REPRODUCE
1. design and position an icon with a unique name in some fallback folder
2. add this folder into the part using QIcon::setFallbackSearchPaths
3. observe that icon is not shown in globalDrawer, buttons, but is shown fine if loaded using IconImage

All works fine with Plasma or Material set as a style using QT_QUICK_CONTROLS_STYLE


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: gentoo; same holds for current flathub platform
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 5.56; kirigami 5.56 or git master
Qt Version: 5.11 and 5.12

ADDITIONAL INFORMATION

Comment 1 Rinigus 2019-03-21 14:01:40 UTC

From discussions on Kirigami IRC, it seemed that the issue is probably in KIconLoader. In particular, it seems that KIconLoader ignores fallback path set by QIcon::setFallbackSearchPaths call.

In my application, problem is evident only in QT_QUICK_CONTROLS_STYLE=org.kde.desktop with all other styles, including Plasma, working as expected. Hence the move to the frameworks-kiconthemes product.

Comment 2 Fab Stz 2019-09-23 07:00:45 UTC

Maybe that is the reason ? 
Does it mean kde doesn't use the pathes set with QIcon::setThemeSearchPaths ?

https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n289

// local embedded icons have preference
icnlibs << QStringLiteral(":/icons");

Comment 3 Nicolas Fella 2020-06-13 22:30:20 UTC

Git commit 19d2ec41fef106de5d60adacbb43f22a90ff6c1b by Nicolas Fella.
Committed on 13/06/2020 at 22:30.
Pushed by nicolasfella into branch 'master'.

Respect QIcon::fallbackSearchpaths()

Summary:
When an icon isn't found within a theme we are supposed to look for it in QIcon::fallbackSearchpaths() (https://doc.qt.io/qt-5/qicon.html#fromTheme).

Test Plan:
Create /home/nico/foo.svg
Add QIcon::setFallbackSearchPaths(QIcon::fallbackSearchPaths() << QStringLiteral("/home/nico/myicons")); to my app
Use foo icon somewhere

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: mart, kossebau, aacid, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29390

M  +17   -0    src/kiconloader.cpp

https://invent.kde.org/frameworks/kiconthemes/commit/19d2ec41fef106de5d60adacbb43f22a90ff6c1b