Summary: | Confirmation dialogs must be optional | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Artiom Neganov <aneganov> |
Component: | tabbar | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate |
Priority: | NOR | ||
Version: | 17.12.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/konsole/2455faf68aafbaf94345d80776a1a0030fd9a8b9 | Version Fixed In: | 19.12.0 |
Sentry Crash Report: |
Description
Artiom Neganov
2019-03-14 23:00:55 UTC
I agree with you. Would you like to try to implement that as your first patch to KDE? I can help you get started. Agreed. If you'd like to submit a patch (it's not hard!) check out https://community.kde.org/Get_Involved/development I can also help. :) I'm surprised this doesn't have an opt out as well. If you want, look at the other dialogs that have the 'Do not ask again" checkbox This is only when trying to close a single tab/session. If you use 'Close Window' or by clicking X in upper right corner, you get the dialog w/ the 'Do not ask again' Git commit 2455faf68aafbaf94345d80776a1a0030fd9a8b9 by Kurt Hindenburg. Committed on 08/10/2019 at 14:48. Pushed by hindenburg into branch 'master'. Add a "Do not ask again" option to close session dialog This is called on Menu->Close Sesssion and right-click tab->Close Tab M +7 -1 src/SessionController.cpp https://invent.kde.org/kde/konsole/commit/2455faf68aafbaf94345d80776a1a0030fd9a8b9 Git commit 2455faf68aafbaf94345d80776a1a0030fd9a8b9 by Kurt Hindenburg. Committed on 08/10/2019 at 14:48. Pushed by scmsync into branch 'master'. Add a "Do not ask again" option to close session dialog This is called on Menu->Close Sesssion and right-click tab->Close Tab M +7 -1 src/SessionController.cpp https://commits.kde.org/konsole/2455faf68aafbaf94345d80776a1a0030fd9a8b9 |