Summary: | Unable to switch television channels by shortcuts | ||
---|---|---|---|
Product: | [Applications] kaffeine | Reporter: | higuita <higuita> |
Component: | general | Assignee: | Antoni Bella <antonibella5> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | antonibella5, wbauer1 |
Priority: | NOR | ||
Version: | 2.0.16-2 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kaffeine/ab5655ef3e9727ad26e7c095d79a64ce4e8b7b28 | Version Fixed In: | |
Attachments: | Solve next and previous items |
Description
higuita
2019-03-09 18:18:44 UTC
Opps, i forgot this info SOFTWARE/OS VERSIONS Linux/KDE Plasma: Slackware64 -current KDE Plasma Version: 5.15.0 KDE Frameworks Version: 5.55.0 Qt Version: 5.12.1 Thanks in advance for the help Updating with a little more info Starting kaffeine with -d do not show anything useful While playing a channel, doing qdbus org.mpris.kaffeine /Player Prev qdbus org.kde.kaffeine /Player Prev Doesn't do anything, nor pressing page-up (or Next/page down) but doing qdbus org.mpris.kaffeine /Player Stop qdbus org.mpris.kaffeine /MainApplication quit do work fine (org.kde.kaffeine also work) i'm using libvlc backend and i tried to followed the code until VlcMediaWidget::jumpToNextChapter(), but yep, i'm totally lost! :D Created attachment 118808 [details] Solve next and previous items Confirmed. This Pull request from GitHub, damage the funcionality of Kaffeine app: -- These icons or menu items do not work: * Next / Previous https://github.com/KDE/kaffeine/pull/3 #- commit ef66906e3d3fda0144e18ed874c32266c1347ab1 vlcmediawidget: fix audio CD playing While here, also fix: - all tracks playing - 'next' & 'previous' working #- My patch revert problematic code to old code. Prove and apply you this patch urgently for next version. Regards Git commit ab5655ef3e9727ad26e7c095d79a64ce4e8b7b28 by Mauro Carvalho Chehab. Committed on 14/03/2019 at 19:52. Pushed by mauroc into branch 'master'. mediawidget: fix a regression with next/previous logic A fix at the CD handing code broke for other sources. After this fix, both prev/next buttons work and also the DBUS equivalent logic: qdbus org.mpris.kaffeine /Player Prev qdbus org.kde.kaffeine /Player Prev Thanks to Antoni Bella for identifying the broken commit and addressing it. Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> M +2 -2 src/mediawidget.cpp https://commits.kde.org/kaffeine/ab5655ef3e9727ad26e7c095d79a64ce4e8b7b28 Thank you both for reporting and finding this issue. Fixup applied. But now switching to the next/previous Audio CD track is broken... :-/ |