Bug 405274

Summary: The Ctrl+Shift+, shortcut for opening KDE apps' Settings window doesn't work on Wayland
Product: [Plasma] kwin Reporter: Richard Bowen <rgb.ide>
Component: wayland-genericAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED UPSTREAM    
Severity: normal CC: bugseforuns, kare.sars, kde, nate
Priority: NOR    
Version: 5.15.3   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Richard Bowen 2019-03-09 17:51:53 UTC 
SUMMARY
The Ctrl+Shift+, shortcut to open the 'Configure Kate' setting dialog doesn't work.

STEPS TO REPRODUCE
1. Click Ctrl+Shift+,
2. Observe the window not appear

OBSERVED RESULT
The Kate settings dialog doesn't get opened when the Ctrl+Shift+, combo is clicked.

EXPECTED RESULT
The Kate settings dialog opens when the Ctrl+Shift+, combo is clicked.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: Linux archlinux 5.0.0-arch1-1-ARCH
(available in About System)
KDE Plasma Version: 5.15.2
KDE Frameworks Version: 5.55.0
Qt Version: 5.12.1

ADDITIONAL INFORMATION
Comment 1 Kåre Särs 2019-03-10 10:30:39 UTC 
I wonder if this is a installation/system problem, because it works here on KDE Neon (Ubuntu 18.04 + latest KDE plasma/frameworks/applications)
Comment 2 Patrick Silva 2019-03-10 14:23:44 UTC 
on wayland? If so, I can confirm on neon dev unstable.
konsole has the same bug - bug 404529
Comment 3 Richard Bowen 2019-03-10 17:32:30 UTC 
Yea, on Wayland. Will mention that from now on.
Comment 4 Nate Graham 2019-03-17 15:46:11 UTC 
Does this shortcut work for *any* KDE apps on Wayland? Or only Kate and Konsole?
Comment 5 Patrick Silva 2019-03-18 15:52:55 UTC 
The same shortcut fails with other kde apps on Wayland: Ark, Dolphin, Gwenview and K3b.
Comment 6 Nate Graham 2019-03-18 15:54:24 UTC 
*** Bug 404529 has been marked as a duplicate of this bug. ***
Comment 7 Martin Flöser 2019-03-18 20:40:25 UTC 
Does it work on Weston?
Comment 8 Patrick Silva 2019-03-18 22:07:34 UTC 
(In reply to Martin Flöser from comment #7)
> Does it work on Weston?

No.
Comment 9 Martin Flöser 2019-03-19 04:52:41 UTC 
As it doesn't work on Weston it's not an issue in the Wayland server, but in the client library.
Comment 10 Nate Graham 2019-03-19 09:49:03 UTC 
Where would we report that?
Comment 11 Martin Flöser 2019-03-19 17:38:00 UTC 
(In reply to Nate Graham from comment #10)
> Where would we report that?

I'm not sure who's responsible for those shortcuts. It might either be a framework or generic Qt functionality.
Comment 12 Nate Graham 2019-03-19 22:07:53 UTC 
The shortcuts are set by us at least, in kstandardshortcuts.
Comment 13 Patrick Silva 2019-04-25 20:23:33 UTC 
So where is the problem? This bug persists.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.57.0
Qt Version: 5.13.0 beta2
Comment 14 David Edmundson 2019-04-26 00:05:12 UTC 
Interesting bug.

QtShortcut is quite smart.
When getting a key event "control+shift+," it converts that into all possible keys that could be  in this case also match "control+shift+<"

It's considered a shortcut match if either of the two match up.

Extracting possible keys requires low level knowledge of the keymap, so it's part of the QPA: virtual QList<int> possibleKeys(const QKeyEvent *)

QtWayland is missing that.
Comment 15 David Edmundson 2019-04-26 00:53:14 UTC 
https://codereview.qt-project.org/#/c/259796/
Comment 16 David Edmundson 2019-05-03 14:09:53 UTC 
Merged in Qt 5.13. Please reopen if it's an issue after that.