Bug 405137

Summary: Original items visible in Thumbnails view
Product: [Applications] digikam Reporter: andrej.valencic
Component: Setup-ImageEditorAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, cmprior, metzpinguin
Priority: NOR    
Version: 6.0.0   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: Version Fixed In: 6.1.0
Sentry Crash Report:

Description andrej.valencic 2019-03-06 10:43:14 UTC
SUMMARY
Option in "Image Editor Settings" to NOT show original images does not work 

STEPS TO REPRODUCE
1. Configure digiKam -> Image Editor Settings
2. Uncheck option Always show original images
3. 

OBSERVED RESULT
Both the original and the changed images (v1) are shown in the album Thumbnails view

EXPECTED RESULT
Original images are supposed to be hidden.

SOFTWARE/OS VERSIONS
Windows: 10 Pro Build 1709
MacOS: 
Linux/KDE Plasma: Ubuntu 18.10
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
This issue is not present in version 5.9.0 - original images are hidden from view.
Comment 1 caulier.gilles 2019-03-06 10:47:49 UTC
Did you use Windows or Linux ?

Gilles Caulier
Comment 2 Maik Qualmann 2019-03-06 10:51:55 UTC
Reload the metadata from these two images.

Maik
Comment 3 andrej.valencic 2019-03-06 10:55:49 UTC
(In reply to caulier.gilles from comment #1)
> Did you use Windows or Linux ?
> 
> Gilles Caulier

Both! Now I'm on Linux as on Windows I reverted to version 5.9.0
Comment 4 Maik Qualmann 2019-03-06 11:00:07 UTC
The cause is a correction of Bug 277502. Read comment 20. Reload the metadata fixes the DB entries.

Maik
Comment 5 andrej.valencic 2019-03-06 11:07:37 UTC
(In reply to Maik Qualmann from comment #4)
> The cause is a correction of Bug 277502. Read comment 20. Reload the
> metadata fixes the DB entries.
> 
> Maik

I'm not sure how to that. I did Album -> Reread Metadata From Files but it still shows the original images as well. Anything else I shoud do?
Comment 6 Maik Qualmann 2019-03-06 11:29:02 UTC
Just tested again, it works with old images with a new version and with newly added where I create a new version. Is it possible to provide the two images? Maybe only as private mail?

Maik
Comment 7 andrej.valencic 2019-03-06 11:42:41 UTC
(In reply to Maik Qualmann from comment #6)
> Just tested again, it works with old images with a new version and with
> newly added where I create a new version. Is it possible to provide the two
> images? Maybe only as private mail?
> 
> Maik

No problem, here are some of those: https://we.tl/t-scma7VFD2t
If you need more (new) ones let me know.
Comment 8 Maik Qualmann 2019-03-06 18:53:59 UTC
Git commit 00d67e8bbfba047e372374ee7c7c10a9dd1272df by Maik Qualmann.
Committed on 06/03/2019 at 18:52.
Pushed by mqualmann into branch 'master'.

revert patch for the item history
Related: bug 277502
FIXED-IN: 6.1.0

M  +2    -2    NEWS
M  +1    -2    core/libs/database/history/itemhistorygraph.cpp

https://commits.kde.org/digikam/00d67e8bbfba047e372374ee7c7c10a9dd1272df
Comment 9 Maik Qualmann 2019-03-06 19:07:08 UTC
I have recovered the behavior of digiKam-5.9.0 but have not reopened Bug 277502 yet. The problem is how to save a new image in the Image Editor. We have 2 entries that are similar. The menu item "Save changes" saves a new image and the original is hidden. The menu item "Save as new version" also creates a new image with the same extension, but is a new branch and the original image is not hidden. Depending on what the user uses, he wonders that the original image is not hidden. So we have to think about whether we can explain it better, or if the original image is also hidden when creating a new branch. I do not think so, maybe use a different file name counter. Gilles, does you know how the correct behavior should be?

Maik
Comment 10 caulier.gilles 2019-03-06 19:21:11 UTC
Well, we need to take a look other softwares which use versioning, as Darktable and lightroom.

https://lightroomkillertips.com/understanding-lightroom-classic-photoshop-workflow/

In this page, the versioning is called "Stack with Original". A file name template is provided and can be customized (for me it's really to much complex and error prone.)

I cannot found the same explanation for Darktable...

Gilles
Comment 11 Maik Qualmann 2019-05-28 09:30:32 UTC
*** Bug 408017 has been marked as a duplicate of this bug. ***