| Summary: | The entire clipboard is cleared out rather than just the last password | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma-pass | Reporter: | tomas.teijeiro |
| Component: | General | Assignee: | Daniel Vrátil <dvratil> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | foss, kde-bugs, med.medin.2014 |
| Priority: | NOR | ||
| Version First Reported In: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-pass/commit/4958d156d682c2a9fe97887244ff7ad4c56b321c | Version Fixed/Implemented In: | 1.2.1 |
| Sentry Crash Report: | |||
|
Description
tomas.teijeiro
2019-03-06 09:31:23 UTC
I have run into almost the same problem. plasma-pass: 1.1.0 Plasma: 5.17.5 Distribution: Debian Unstable plasma-pass not only does not copy the password to the clipboard but instead it clears up my entire clipboard. I see below messages in the logs. rrs@priyasi:~/rrs-home/Community/plasma-pass (master)$ org.kde.plasma.pass: ServiceJob for clipboard failed internally, falling back to clearClipboard() The same problem on Plasma 5.21.5, this bug lets this great app totally unusable. Same started to happen for me as well:
Operating System: Arch Linux
KDE Plasma Version: 5.26.1
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6
Kernel Version: 6.0.2-arch1-1 (64-bit)
Graphics Platform: X11
Relevant entries in journal logs:
plasmashell[26963]: file:///usr/share/plasma/plasmoids/org.kde.plasma.pass/contents/ui/PasswordItemDelegate.qml:63:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
plasmashell[26963]: org.kde.plasma.pass: ServiceJob for clipboard failed internally, falling back to clearClipboard()
Just to note, I have created a new user and started from clean profile (home folder) and managed to reproduce the issue. Git commit 4958d156d682c2a9fe97887244ff7ad4c56b321c by Daniel Vrátil. Committed on 01/03/2023 at 21:59. Pushed by dvratil into branch 'master'. Fix entire clipboard history being always wiped by Plasma Pass Modern Klipper supports x-kde-passwordManagerHint and won't store items marked with this hint in the clipboard history. Back when I was writing Plasma Pass this feature wasn't merged yet. Plasma Pass was ready for it but it also had to support the current version of Klipper at that time, so it always go and try to remove the password from Klipper's history. When new Klipper with support for x-kde-passwordManagerHint was released Plasma Pass would still try to remove the password from Klipper's clipboard history but would always fail (since Klipper doesn't store passwords in history anymore). This would trigger a safety fallback inside Plasma Pass that just wipes entire Klipper history, just to be sure. With this fix, Plasma Pass will only attempt to remove the password from Klipper's history if it detects an old Klipper that doesn't support the hint yet. FIXED-IN: 1.2.1 M +2 -0 plugin/CMakeLists.txt A +61 -0 plugin/klipperutils.cpp [License: LGPL(v2.1+)] A +20 -0 plugin/klipperutils.h [License: LGPL(v2.1+)] M +27 -2 plugin/providerbase.cpp M +4 -0 plugin/providerbase.h https://invent.kde.org/plasma/plasma-pass/commit/4958d156d682c2a9fe97887244ff7ad4c56b321c |