| Summary: | Digikam::DigikamApp::slotSolidDeviceChanged: slotSolidDeviceChanged: messages referring to directory that digikam should not care about | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Simon J Mudd <sjmudd> |
| Component: | Database-Media | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, johannes.hirte, kde.org, metzpinguin |
| Priority: | NOR | ||
| Version First Reported In: | 6.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Appimage | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/0f12c357bf574f6719779040574cb094bd5e18a1 | Version Fixed/Implemented In: | 6.1.0 |
| Sentry Crash Report: | |||
|
Description
Simon J Mudd
2019-02-28 07:47:29 UTC
Observed the same. Hotpluging some storage can lead to an infinite loop where digikam get's unresponsive. I've seen this with NFS shares and CD/DVD drive. When this happens, I get the following log message: digikam.general: slotSolidDeviceChanged: "/org/freedesktop/UDisks2/block_devices/sr0" This repeats until I kill digikam. For now I can't reproduce this reliably. The media notifications are relevant of KF5::Solid interface. In AppImage, we are frozen to KF5 v5.54 due to use Qt 5.9.7. NExt version of KF5 will require Qt 5.10 at least, so i will need to update the CentOS install with a more recent Qt5 version. This will take time to do... Gilles Caulier Just for info, I have the bug with Gentoo: Qt5: 5.12.1 KF5: git master (>v5.55.0-rc1) Plasma: git master (>v5.15.0) Digikam: 6.0.0 Maik, That must mean that we need to filter the event send by Solid when a device contents is changed. But i thinking that we already do it somewhere... Or perhaps something has changed in the core Solid implementation. Gilles I have a look in the code. This occurs when the signals deviceAdded() or deviceRemoved() are constantly sent by Solid, digiKam constantly rebuilds the device menu. In principle, Solid is not allowed to constantly send these signals for one and the same device. We could slow that down... Maik Oh, I see we connect the signal with the slot again and again. Maik Git commit 0f12c357bf574f6719779040574cb094bd5e18a1 by Maik Qualmann. Committed on 28/02/2019 at 19:31. Pushed by mqualmann into branch 'development/dplugins'. fix multiple new signal/slot connections from Solid device interface FIXED-IN: 6.1.0 M +2 -1 NEWS M +11 -1 core/app/main/digikamapp_camera.cpp M +0 -7 core/app/main/digikamapp_solid.cpp https://commits.kde.org/digikam/0f12c357bf574f6719779040574cb094bd5e18a1 *** Bug 405954 has been marked as a duplicate of this bug. *** |