Bug 404829

Summary: Option to auto-accept rectangular region box on mouse release
Product: [Applications] Spectacle Reporter: Nate Graham <nate>
Component: GeneralAssignee: Boudhayan Gupta <me>
Status: RESOLVED FIXED    
Severity: wishlist CC: bugseforuns
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/spectacle/bda92cdc26818ff1752c77dfc775337571425b8f Version Fixed In: 19.04.0
Sentry Crash Report:

Description Nate Graham 2019-02-26 04:30:18 UTC 
Right now, a rectangular region box must be manually accepted by hitting return/enter or double-clicking in it after it's been drawn. This works fine when you want to adjust the box after initially drawing it, but is less great when your initial selection was good (or good enough), or precision is not important.

It would be nice if there was a way to have Spectacle automatically accept the box after it's been drawn and the mouse button is released.
Comment 1 Nate Graham 2019-03-06 17:49:27 UTC 
Git commit bda92cdc26818ff1752c77dfc775337571425b8f by Nate Graham, on behalf of Nils Rother.
Committed on 06/03/2019 at 17:49.
Pushed by ngraham into branch 'master'.

Add option to auto-accept box selection on mouse release

Summary:
Adds the option to have spectacle accept the selected region as soon
as the mouse button is released, similar to how other screenshot tools
allow it (eg. scrot -s).

Test Plan:
To enable the option go to
Configure -> General -> Rectangular Region -> Accept region on mouse release
then set the Capture mode to Rectangular Region and take a new screenshot.

{F6657239}

Behaviour should be the following:
  -When selecting a new region, without a previously saved region available,
   click->drag->release should immediately capture the selected region.
  -When a previously saved region is shown, the saved region can be
   manipulated further and saving this region requires manual confirmation
   (Enter/Double LMB).
  -Clicking and dragging outside of the previously saved region
   captures the newly selected region immediately.

Reviewers: #vdg, #spectacle, ngraham

Reviewed By: #vdg, #spectacle, ngraham

Subscribers: ngraham, #spectacle

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D19525

M  +7    -0    src/Gui/SettingsDialog/GeneralOptionsPage.cpp
M  +1    -0    src/Gui/SettingsDialog/GeneralOptionsPage.h
M  +86   -22   src/QuickEditor/QuickEditor.cpp
M  +7    -2    src/QuickEditor/QuickEditor.h
M  +13   -0    src/SpectacleConfig.cpp
M  +3    -0    src/SpectacleConfig.h

https://commits.kde.org/spectacle/bda92cdc26818ff1752c77dfc775337571425b8f