| Summary: | Presentation offset from full screen when OpenGL transitions selected. | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Tim <tims_tank> |
| Component: | Plugin-Generic-Presentation | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version First Reported In: | 6.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/digikam/464fba508bcdc548b2916cacb466ca4d6aaa6773 | Version Fixed/Implemented In: | 6.1.0 |
| Sentry Crash Report: | |||
| Attachments: |
Digikam Presentation Bug screen shot
Digikam Presentation Bug screen shot 2 |
||
This can be a bug from Qt 5.11 used with Windows bundle. A new preview version of next digiKam 6.1.0 was build using Qt 5.12. Can you reproduce this problem with this installer : https://files.kde.org/digikam/ Gilles Caulier Git commit 464fba508bcdc548b2916cacb466ca4d6aaa6773 by Maik Qualmann. Committed on 26/02/2019 at 17:34. Pushed by mqualmann into branch 'development/dplugins'. fix openGL screen position from Presentation tool FIXED-IN: 6.1.0 M +2 -1 NEWS M +9 -7 core/dplugins/generic/view/presentation/opengl/presentationgl.cpp M +1 -1 core/dplugins/generic/view/presentation/opengl/presentationkb.cpp https://commits.kde.org/digikam/464fba508bcdc548b2916cacb466ca4d6aaa6773 Thanks Gilles and Maik. The build from Gilles link (digiKam-6.1.0-git-20190224T141538-Win64.exe) still has the bug. Is there a build with Maik's fix for me to test? Tim. I will start the build today morning Gilles Caulier Created attachment 118548 [details]
Digikam Presentation Bug screen shot 2
I have tested digiKam-6.1.0-git-20190303T140555-Win64.exe on two Windows machines and the OpenGL transitions Presentation offset (down and to the right) seems to be gone. But there is still an offset of a few pixels when view a presentation. This does not seem to be related to OpenGL, as is is present whether the OpenGL tansitions checkbox is selected or not. See my screen shot in Comment 5. Tim. I can not reproduce the free area on the right side of the screen here. So far tested on a real Windows7 and virtual machine. Test with Windows10 follows... Maik As noted, I am using Windows 10. I just tried another install on a different Windows 10 machine and the same issue is present. The Presentation being offset a little, exposing a few pixels of Desktop on the right side of the screen. I have tried machines with varying display resolutions and the issue is always present. Thanks, Tim. Git commit ac5e5668a70a2709627c15a309da14f4a1e233cc by Maik Qualmann. Committed on 06/03/2019 at 21:16. Pushed by mqualmann into branch 'master'. try to fix fullscreen size under Windows10 M +2 -1 core/dplugins/generic/view/presentation/opengl/presentationgl.cpp M +2 -2 core/dplugins/generic/view/presentation/opengl/presentationkb.cpp M +2 -2 core/dplugins/generic/view/presentation/widgets/presentationwidget.cpp https://commits.kde.org/digikam/ac5e5668a70a2709627c15a309da14f4a1e233cc Tim, I updated the Windows installer with last changes from Maik : https://files.kde.org/digikam/ Please confirm that all is fixed properly. Thanks in advance... Gilles Caulier The resolution under OpenGL is now broken under Windows7 here. I'll watch it tonight. Maik Gilles and Maik, I have just tested digiKam-6.1.0-git-20190308T103035-Win64.exe on Windows 10, and all the issues I observed look resolved. That is, neither the original OpenGL offset, nor the smaller few pixels of Desktop down the right screen edge remain present in Presentations. I don't have Windows 7 so can't help with testing that, sorry. Thanks for all your work on DigiKam. Tim. Tim, Thanks for the feedback. I tried new Presentation plugin patched by Maik, and i cannot see any visual glitch under Windows 7. Gilles Caulier |
Created attachment 118365 [details] Digikam Presentation Bug screen shot SUMMARY When using the DigiKam Presentation function with OpenGL transitions selected, the presentation is offset from full screen. It is moved a little down and to the right. I have tried on two Windows 10 Pro version 1809 build 17763.316 boxes, both exhibit the same behaviour. If you remove the OpenGL transitions, the presentation displays correctly. STEPS TO REPRODUCE 1. Select photos 2. Select Presentation 3. Ensure Use OpenGL transitions is ticked 4. Start the presentation OBSERVED RESULT The presentation does not display full screen, but is moved a little down and to the right, with the underlying DigiKam screen being slightly revealed. EXPECTED RESULT The presentation occupies the full screen it is being displayed upon. SOFTWARE/OS VERSIONS Windows: Windows 10 Pro version 1809 build 17763.316 MacOS: not tested Linux/KDE Plasma: not tested (available in About System) KDE Plasma Version: windows KDE Frameworks Version: 5.49.0 Qt Version: 5.11.2 ADDITIONAL INFORMATION screen shot attached