Summary: | Mergedimage.png isn't rendered correctly in master. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | wolthera <griffinvalley> |
Component: | File formats | Assignee: | Dmitry Kazakov <dimula73> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | halla |
Priority: | NOR | Keywords: | regression, release_blocker |
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
wolthera
2019-02-23 15:09:59 UTC
Probably the same root cause as https://bugs.kde.org/show_bug.cgi?id=404976 -- instead of just copying the projection and not touching that when making the saving clone, the cloned image starts re-rendering itself. At least, that's what I suspect. Git commit 741608695618b9a5e9d0d7f4790fa45bb27a979b by Dmitry Kazakov. Committed on 22/04/2019 at 19:41. Pushed by dkazakov into branch 'master'. Add sanity check for the image being idle after cloning M +4 -0 libs/ui/KisDocument.cpp https://invent.kde.org/kde/krita/commit/741608695618b9a5e9d0d7f4790fa45bb27a979b Git commit f984eab0aa72495867b67c51a68531093d086729 by Dmitry Kazakov. Committed on 22/04/2019 at 19:41. Pushed by dkazakov into branch 'master'. Fix artifacts when saving vector layers into PNG files This patch has two parts: 1) KisShapeLayer should block the updates of the shape-canvas. When shapes are added to the layer, they initiate shape manager updates. That is not what we want, because all the rendered pixel data has already been copied in initShapeLayer() call. 2) Add a sanity check in KisDocument::initiateSavingInBackground(). Theoretically, there should be no pending updates after cloning operation. But if they still appear somehow (which is a bug), just force them wait until they complete their execution. Related: bug 404976 M +7 -0 libs/image/KisDelayedUpdateNodeInterface.h M +11 -0 libs/image/kis_layer_utils.cpp M +1 -0 libs/image/kis_layer_utils.h M +6 -1 libs/image/kis_transform_mask.cpp M +1 -0 libs/image/kis_transform_mask.h M +17 -0 libs/ui/KisDocument.cpp M +5 -0 libs/ui/flake/KisReferenceImagesLayer.cpp M +9 -0 libs/ui/flake/kis_shape_layer.cc M +5 -0 libs/ui/flake/kis_shape_layer.h M +25 -3 libs/ui/flake/kis_shape_layer_canvas.cpp M +8 -0 libs/ui/flake/kis_shape_layer_canvas.h https://invent.kde.org/kde/krita/commit/f984eab0aa72495867b67c51a68531093d086729 Hi, Wolthera! Could you please check if the bug still appears in master? I have fixed the problems caused by vector layers trying to update themselves after cloning. But I cannot reproduce the steps you listed... and I cannot see how they can cause any problems. I've also added a safe assert in the saving code. If the image is not idle during saving operation (e.g. it is updating something), it will show an assert. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |