Bug 404706

Summary: Regression: virtual desktop no longer shown in tooltip
Product: [Plasma] plasmashell Reporter: Christian (Fuchs) <kde>
Component: Task Manager and Icons-Only Task Manager widgetsAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: normal CC: bugseforuns, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.15.1   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-desktop/d769b7aa8838e95e20aa3b52ae5a0db575111416 Version Fixed/Implemented In: 5.15.3
Sentry Crash Report:

Description Christian (Fuchs) 2019-02-22 18:53:13 UTC 
SUMMARY
The virtual desktop the task is on was shown in the tooltip before. 
This no longer works (under X11)

STEPS TO REPRODUCE
1. Use X11
2. Have multiple virtual Desktops
3. Hover an open window in the task manager

OBSERVED RESULT
Tooltip subtext lacks virtual desktop

EXPECTED RESULT
Tooltip shows virtual desktop

This seems to be caused in 

var vd = isGroup ? VirtualDesktop : virtualDesktopParent;


Which used to work, but now VirtualDesktop is either undefined or at least not the type it expects it to be. Very likely to be caused by 
https://github.com/KDE/plasma-workspace/commit/52d760c57c2433a25c2c3b375ae8a51328271d00
and subsequent work in that area. 

Thanks in advance for fixing :)
Comment 1 Eike Hein 2019-02-23 17:11:25 UTC 
Patch under review: https://phabricator.kde.org/D19257
Comment 2 Eike Hein 2019-03-11 16:29:26 UTC 
Git commit d769b7aa8838e95e20aa3b52ae5a0db575111416 by Eike Hein.
Committed on 11/03/2019 at 16:28.
Pushed by hein into branch 'Plasma/5.15'.

[Task Manager] Fix virtual desktops subtext on task tooltip

Summary: BUG:404706

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: apol, Fuchs, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19257

M  +1    -1    applets/taskmanager/package/contents/ui/Task.qml
M  +1    -1    applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
M  +8    -5    applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/d769b7aa8838e95e20aa3b52ae5a0db575111416