Bug 404639

Summary:	Shrunk "View Start Profile" window
Product:	[Applications] kstars	Reporter:	Jean-Claude <jcjesior>
Component:	general	Assignee:	Jasem Mutlaq <mutlaqja>
Status:	REPORTED ---
Severity:	normal	CC:	jcjesior, rlancaste
Priority:	NOR
Version First Reported In:	2.9.8
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Shrunk star profile

Description Jean-Claude 2019-02-21 09:39:15 UTC

SUMMARY
When called in the Focuser panel, the "View Start Profile" displays nicely the first time but doesn't work when called a SECOND TIME.

STEPS TO REPRODUCE
- Run the Simulator
- Focuser panel : use the Telescope Control to find a nice star
- Click on the "View Start Profile" button to get a nice profile
- Close the "View Start Profile" window

OBSERVED RESULT
- Click on the "View Start Profile" button a second time
- the window is shrunk and unreadable
- you must restart KStars to get a full window again

EXPECTED RESULT
See attached doc : the shrunk window is indicated

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 10.14.3
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
KStars 3.0.0

Comment 1 Jean-Claude 2019-03-05 17:15:40 UTC

Oooops, I forgot to add a screenshot

Comment 2 Jean-Claude 2019-03-05 17:16:57 UTC

Created attachment 118579 [details]
Shrunk star profile

Comment 3 Rob 2019-03-09 02:05:51 UTC

I fixed this in 3.1.0.  Please test with the later version.  This was indeed an issue before.  It was some trouble we were having using the QT method for creating windows for content like the DataVisualizations used by Star Profile Viewer and like the QTQuick used by the Whats Interesting panel.  The issues should now be resolved.

Comment 4 Jean-Claude 2019-03-09 06:02:12 UTC

Hi Rob, the issue is not resolved in 3.1.0

Comment 5 Jean-Claude 2019-03-10 20:52:18 UTC

Hi Rob, I just downloaded and tested v. 3.1.1
The bug is not present anymore in the CCD and Align modules, but is still present in the Focus and Guide modules.
Concerning solving, 3.1.1 works as expected directly.

Comment 6 Rob 2019-03-10 21:38:10 UTC

Gotcha, I will look at it.

Comment 7 Rob 2019-03-12 00:25:34 UTC

Yep, you were quite right.  When I made the revisions before 3.1.0 to fix the issues with the star profile viewer appearing, I put the changes into an existing if statement

if(mode == FITS_NORMAL || mode == FITS_ALIGN)

So the fix did not apply to Guide and Focus views.  

I just sent a revision to Jasem with the code a bit rearranged so that the fix is now outside the if statement so it works for all star profile views.

Comment 8 Jean-Claude 2019-03-12 07:06:33 UTC

Thanks a lot Rob.

Comment 9 Rob 2019-03-12 17:11:24 UTC

thank you too!  I hadn't even realized that I had only fixed it for a couple of fitsview types.  It might be a little while before we have a new dmg with the change however, to let you know, because I think that they will want to fix more bugs before releasing another version.  If you need it sooner than that, you can run my new OS X build script https://github.com/rlancaste/kstars-on-osx-craft to get it yourself.

Comment 10 Jean-Claude 2019-03-12 17:58:30 UTC

Rob, I followed the instructions of https://github.com/rlancaste/kstars-on-osx-craft
No problem encountered during the procedure with Terminal.
A folder named AstroRoot had been created
~/AstroRoot/kstars-craft/download
But this download folder is empty...

Anyhow: Bravo et encore bravo, Rob ! I'm really impressed !

Comment 11 Jean-Claude 2019-03-12 18:12:52 UTC

I think that one of the command line doesn't create the right folders .
Terminal says somewhere:
cp: directory /Users/JCJ/AstroRoot/kstars-craft/etc does not exist