Bug 404614

Summary:	OpenVPN reneg-sec option max arbitrarily set to 604800 seconds
Product:	[Plasma] plasmashell	Reporter:	Clarence Risher <sparr0>
Component:	Networking in general	Assignee:	Jan Grulich <jgrulich>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Ubuntu
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-nm/de649a3b3a219adb37b00f24329d0734c7e7a235	Version Fixed/Implemented In:
Sentry Crash Report:

Description Clarence Risher 2019-02-20 18:58:21 UTC

SUMMARY

https://github.com/KDE/plasma-nm/blob/b7ac6986190443a47f583bea1084e25075a0cdc6/vpn/openvpn/openvpn.cpp#L305-L308

I cannot find documentation supporting this upper limit. The standard openvpn client accepts much larger values (at least 2**31-1, I think).


STEPS TO REPRODUCE
1. install network-manager-openvpn
2. attempt to import a .ovpn configuration with "reneg-sec 2592000"

OBSERVED RESULT

error dialog "Invalid size (should be between 0 and 604800) in option: reneg-sec 2592000"

EXPECTED RESULT

connection successfully imported

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 19.04
(available in About System)
KDE Plasma Version: 5.14.90
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION

The limit is also enforced in the Network Manager GUI:

https://bazaar.launchpad.net/~network-manager/network-manager-openvpn/trunk/view/903/properties/nm-openvpn-dialog.ui#L13

Previous discussion of this limit in the Gnome bug tracker:

https://bugzilla.gnome.org/show_bug.cgi?id=639560

Comment 1 Jan Grulich 2019-03-27 15:11:37 UTC

Git commit 6772557eb0e9e281db1b838712b94d4fce00b690 by Jan Grulich.
Committed on 27/03/2019 at 15:10.
Pushed by grulich into branch 'master'.

OpenVPN: reneg-sec property doesn't need limitation

M  +1    -5    vpn/openvpn/openvpn.cpp
M  +0    -3    vpn/openvpn/openvpnadvanced.ui

https://commits.kde.org/plasma-nm/6772557eb0e9e281db1b838712b94d4fce00b690

Comment 2 Jan Grulich 2019-03-29 10:14:17 UTC

Git commit de649a3b3a219adb37b00f24329d0734c7e7a235 by Jan Grulich.
Committed on 29/03/2019 at 10:13.
Pushed by grulich into branch 'Plasma/5.15'.

OpenVPN: reneg-sec property doesn't need limitation

M  +1    -5    vpn/openvpn/openvpn.cpp
M  +0    -3    vpn/openvpn/openvpnadvanced.ui

https://commits.kde.org/plasma-nm/de649a3b3a219adb37b00f24329d0734c7e7a235

Comment 3 Ben Cooksley 2024-12-23 18:23:43 UTC

Bulk transfer as requested in T17796