Bug 404536

Summary: Look and Feel KCM prompts to save/discard (no) changes when I try to close system settings after theme preview
Product: [Applications] systemsettings Reporter: Patrick Silva <bugseforuns>
Component: kcm_lookandfeelAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version: 5.16.4   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/kdeclarative/661695fdc532547d56b4a857ca57146c2a0a3c06 Version Fixed In: 5.62

Description Patrick Silva 2019-02-18 20:52:14 UTC 
STEPS TO REPRODUCE
1. open system settings > Look and Feel
2. preview any theme but your current theme by clicking its play button
3. close theme preview, try to close system settings

OBSERVED RESULT
system settings prompts to save/discard changes, but I changed nothing

EXPECTED RESULT
system settings closes without save/discard prompt

SOFTWARE/OS VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.0


ADDITIONAL INFORMATION
Same issue affects Splash Screen kcm
Comment 1 Nate Graham 2019-02-19 17:27:42 UTC 
Can reproduce in git master, but not in 5.14.5.
Comment 2 Patrick Silva 2019-08-06 17:37:14 UTC 
look and feel kcm is also affected.
Comment 3 Patrick Silva 2019-08-06 17:39:16 UTC 
ops, I meant Splash Screen kcm is also affected lol
Comment 4 Nate Graham 2019-08-06 18:01:20 UTC 
I think this was my fault. I made it select an inactive item when that item's action button is clicked. So in this case it means that when you click the preview button for an inactive theme, it selects that theme, which marks the page as dirty and prompts you to save when you navigate away. Maybe that was a mistake.
Comment 6 Nate Graham 2019-08-06 18:12:30 UTC 
Patch: https://phabricator.kde.org/D22975
Comment 7 Nate Graham 2019-08-06 18:23:19 UTC 
Git commit 661695fdc532547d56b4a857ca57146c2a0a3c06 by Nate Graham.
Committed on 06/08/2019 at 18:23.
Pushed by ngraham into branch 'master'.

[GridDelegate] Don't select unselected item when clicking on any of its action buttons

Summary:
In 6258f33fce3af55f7cdd3b5487cd04d8e53c0b38, I changed the delegate action button
behavior to select an unselected item when any of its buttons were clicked. In
retrospect, this was a mistake and causes various issues with items becoming selected
when they shouldn't be.

This patch reverts that part of the change to the prior behavior.
FIXED-IN: 5.62

Test Plan:
Preview an unselected LNF theme or splash screen and navigate away from the KCM; no
"unsaved changes" dialog

Click on the delete or show in folder button on an unselected wallpaper item; still works

Reviewers: broulik, #plasma

Reviewed By: broulik, #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22975

M  +1    -4    src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

https://commits.kde.org/kdeclarative/661695fdc532547d56b4a857ca57146c2a0a3c06