Bug 404519

Summary:	Adding Hold Frames to a horizontal range often removes selection
Product:	[Applications] krita	Reporter:	Bollebib <kwadraatnope>
Component:	Animation	Assignee:	Eoin O'Neill <eoinoneill1991>
Status:	RESOLVED FIXED
Severity:	normal	CC:	eoinoneill1991, griffinvalley
Priority:	NOR	Keywords:	triaged
Version:	4.1.7
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/krita/commit/68a0cf3e32e6ad857ac275a65a5719930bad74cd	Version Fixed In:
Sentry Crash Report:

Description Bollebib 2019-02-18 12:48:50 UTC

if you select a column on a single frame and then use shortcuts to add 1 hold each time,the selection is maintained and works correctly


when you select multiple frames on the same layer ->de selection is removed after one operation.


The selection MUST be maintained,always until you unselect yourself.


this should also be the case for removing a hold.

Comment 1 wolthera 2019-03-06 09:28:51 UTC

I can't reproduce this in the nightly builds, can you?

Comment 2 Bollebib 2019-03-13 12:58:39 UTC

https://www.youtube.com/watch?v=VuL3ZRMttsg&feature=youtu.be



It still happens in today's nightly

At a certain moment I DID get to keep the selection. But then another issue arose


if you ADD to the selection
then the later selected frames go out of bounds of the selection

The selection should grow and shrink with the frames for the most consitant behaviour.

Comment 3 wolthera 2019-09-21 16:03:35 UTC

Yeah, seeing it now, I can confirm this.

Comment 4 wolthera 2019-09-27 14:32:57 UTC

Assigning this to Tyyppi

Comment 5 Eoin O'Neill 2020-07-28 22:40:55 UTC

I'm going to address this issue now.

Comment 6 Eoin O'Neill 2020-07-29 03:40:41 UTC

Git commit d76c59fca3fad96ddf299b4f36d951fb10105259 by Eoin O'Neill.
Committed on 29/07/2020 at 03:40.
Pushed by eoinoneill into branch 'krita/4.3'.

Fix: Properly Maintain Selection of Keyframes When Inserting / Removing Hold Frames.

Related Feature: Preserve multi-frame selection when active frame changes. Useful
for preserving the users selection on scrub, but also less error-prone when dealing
with modifying the user selection while concurrent "switch-time" operation is running.

Insert Keyframe Bug:
Related: bug 388779

Maintain Multiframe Selection Wishlist:

M  +1    -1    plugins/dockers/animation/timeline_frames_model.cpp
M  +1    -1    plugins/dockers/animation/timeline_frames_model.h
M  +37   -1    plugins/dockers/animation/timeline_frames_view.cpp
M  +1    -0    plugins/dockers/animation/timeline_frames_view.h

https://invent.kde.org/graphics/krita/commit/d76c59fca3fad96ddf299b4f36d951fb10105259

Comment 7 Eoin O'Neill 2020-07-29 05:26:48 UTC

Git commit 68a0cf3e32e6ad857ac275a65a5719930bad74cd by Eoin O'Neill.
Committed on 29/07/2020 at 03:42.
Pushed by eoinoneill into branch 'master'.

Fix: Properly Maintain Selection of Keyframes When Inserting / Removing Hold Frames.

Related Feature: Preserve multi-frame selection when active frame changes. Useful
for preserving the users selection on scrub, but also less error-prone when dealing
with modifying the user selection while concurrent "switch-time" operation is running.

Insert Keyframe Bug:
Related: bug 388779

Maintain Multiframe Selection Wishlist:

(commit cherry-picked from krita/4.3 d76c59fca3fad96ddf299b4f36d951fb10105259)

M  +1    -1    plugins/dockers/animation/timeline_frames_model.cpp
M  +1    -1    plugins/dockers/animation/timeline_frames_model.h
M  +36   -0    plugins/dockers/animation/timeline_frames_view.cpp
M  +1    -0    plugins/dockers/animation/timeline_frames_view.h

https://invent.kde.org/graphics/krita/commit/68a0cf3e32e6ad857ac275a65a5719930bad74cd