| Summary: | Global menu applet is unusable (5.15 regression) | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Antonio Rojas <arojas> |
| Component: | Global Menu widget | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, mathias.ciliberto, mvourlakos, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.15.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/f6bf54808f32390009fdf6cdbb52627670be733a | Version Fixed/Implemented In: | 5.15.2 |
| Sentry Crash Report: | |||
| Attachments: | Output of env command | ||
|
Description
Antonio Rojas
2019-02-17 22:10:22 UTC
That commit was from me, what are the steps to reproduce? I tried to reproduce in my plasma 5.15.0 system and I cant. Add a global menu applet to the panel Open any application (eg. dolphin) - the menu is not displayed Switch to another window in the task manager and switch back to dolphin - the menu is displayed now in the applet Click anywhere on the dolphin window - the menu disappears. I can reproduce in two different systems So strange I can't, for the record current code for screen awareness is based at https://phabricator.kde.org/D17107 I tried also the following: 1. Started with a clean desktop 2. I added an "Application Menu Bar" panel 3. I opened Dolphin (menu appears and works fine) 4. I opened KWrite and switched between Dolphin and KWrite, global still worked ok (In reply to Antonio Rojas from comment #2) > Do the above steps reproduce the bug for you? I've traced this to the following line in kdeglobals: [KScreen] ScaleFactor=2 ScreenScaleFactors=eDP-1=2;DP-1=2; ^^^ Removing the "ScreenScaleFactors" line fixes the issue (but breaks display scaling) (In reply to Antonio Rojas from comment #5) > I've traced this to the following line in kdeglobals: > > [KScreen] > ScaleFactor=2 > ScreenScaleFactors=eDP-1=2;DP-1=2; > ^^^ > > Removing the "ScreenScaleFactors" line fixes the issue (but breaks display > scaling) show me your "env" output please *** Bug 404528 has been marked as a duplicate of this bug. *** Created attachment 118187 [details]
Output of env command
As requested in the duplicated bug, here my env output.
(In reply to Mathias C. from comment #8) > Created attachment 118187 [details] > Output of env command > > As requested in the duplicated bug, here my env output. all the problem comes from that: PLASMA_USE_QT_SCALING=1 as plasma devs have reported it is suggested to NOT enable this because it breaks so many things including the screen geometries. Meaning that if you enable this option any screen geometries comparisons are NOT valid. In that specific issue the window can not be identified that it belongs to current screen. I suppose that filter by screen from the plasma taskmanager could be also another breakage. So, I will leave this to Plasma devs to decide what to do with the issue and afterwards I can provide a fix. (In reply to Mathias C. from comment #8) > Created attachment 118187 [details] > Output of env command > > As requested in the duplicated bug, here my env output. for confirmation, you are using X11 or wayland environment? From the env:
for confirmation, you are using X11 or wayland environment?
>XDG_SESSION_TYPE=x11
So random vars were set by the user.
This is not a bug.
(In reply to David Edmundson from comment #11) > From the env: > > for confirmation, you are using X11 or wayland environment? > >XDG_SESSION_TYPE=x11 > > So random vars were set by the user. > > This is not a bug. That is not a random var. That is the only way to have Plasma desktop currently scaled properly on a HiDPI panel, as even yourself suggested on https://bugs.kde.org/show_bug.cgi?id=356446. Without that variable, the icons of the desktop and the spacing of the menu items on the desktop are wrong. So, it may not be a bug of the global menu applet, but there is definitely a bug somewhere. Also, considering that according to this https://bugs.kde.org/show_bug.cgi?id=356446, some bugs have been fixed aiming to make PLASMA_USE_QT_SCALING=1 the default behaviour under X11 (e.g. https://phabricator.kde.org/D11244), wouldn't be possible to implement a fix to this issue too when that variable is set? Git commit 39d220b4b6577c2c6e027f4b15ab011b4c7a5fbc by Michail Vourlakos. Committed on 20/02/2019 at 18:21. Pushed by mvourlakos into branch 'master'. block screen filtering for global menu applet Summary: --when the user has enabled PLASMA_USE_QT_SCALING under X11 environment the screen and window geometries can not be trusted for comparison. In such case the global menu should be always visible Test Plan: check that global menu still works properly Reviewers: #plasma, davidedmundson, broulik Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D19126 M +11 -1 applets/appmenu/plugin/appmenumodel.cpp https://commits.kde.org/plasma-workspace/39d220b4b6577c2c6e027f4b15ab011b4c7a5fbc Git commit f6bf54808f32390009fdf6cdbb52627670be733a by Michail Vourlakos. Committed on 20/02/2019 at 18:25. Pushed by mvourlakos into branch 'Plasma/5.15'. improve screen filtering for global menu applet Summary: --when the user has enabled PLASMA_USE_QT_SCALING under X11 environment the screen and window geometries can not be trusted for comparison before window geometries have been adjusted properly FIXED-IN: 5.15.2 Test Plan: check that global menu still works properly Reviewers: #plasma, davidedmundson, broulik Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D19126 M +11 -1 applets/appmenu/plugin/appmenumodel.cpp https://commits.kde.org/plasma-workspace/f6bf54808f32390009fdf6cdbb52627670be733a |