Bug 404463

Summary: timeline refactor 2019-02-17 able to drag marker off the timeline
Product: [Applications] kdenlive Reporter: Evert Vorster <evorster>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal CC: fritzibaby
Priority: NOR Flags: fritzibaby: timeline_corruption+
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Screenshot of the pointer in an impossible position

Description Evert Vorster 2019-02-17 05:45:10 UTC
Created attachment 118146 [details]
Screenshot of the pointer in an impossible position

SUMMARY
When adding keyframes to a transition, it is possible to drag the marker off the timeline indication in the transition editor with the mouse.
This makes no sense, as it is not possible to add a keyframe outside of the clip.


STEPS TO REPRODUCE
1. Add a transition on the timeline
2. Go to the transition editor and drag the marker all the way to the right.

OBSERVED RESULT
Being able to drag the marker to a place that makes no sense. 

EXPECTED RESULT
Marker should stop at the last frame of the transition.

SOFTWARE/OS VERSIONS
Arch Linux updated 2019-02

ADDITIONAL INFORMATION
This may seem like a small niggle, but it did take me some time to figure out why I am not able to add a keyframe at the end of my clip...
Comment 1 Jean-Baptiste Mardelle 2019-02-17 10:42:13 UTC
Git commit 491d80de89741046320d5d87657bbdc1a9f1f022 by Jean-Baptiste Mardelle.
Committed on 17/02/2019 at 10:41.
Pushed by mardelle into branch 'refactoring_timeline'.

Ensure keyframes cannot be dragged outside item range

M  +17   -14   src/assets/keyframes/view/keyframeview.cpp
M  +1    -0    src/assets/keyframes/view/keyframeview.hpp
M  +36   -8    src/timeline2/view/qml/KeyframeView.qml
M  +1    -0    src/transitions/view/transitionstackview.cpp

https://invent.kde.org/kde/kdenlive/commit/491d80de89741046320d5d87657bbdc1a9f1f022
Comment 2 Evert Vorster 2019-02-18 05:12:39 UTC
Confirmed fixed.

Thanks, JBM.