Bug 404366

Summary: Problem saving files
Product: [Applications] kig Reporter: David Utidjian <david.utidjian>
Component: generalAssignee: David E. Narvaez <david.narvaez>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description David Utidjian 2019-02-14 20:13:58 UTC 
SUMMARY
Installed Kig from normal repos for my distribution (Fedora 29). But when I tried the program it would not save files easily. I had to specify an extension (.kig) that I guessed would work. It did.


STEPS TO REPRODUCE
1. Open Kig application and draw something.
2. Click File > Save (or Save as)and the expected file window pops up in my Documents folder.
3. Type in a new name, in this case 'testkig' (no extension and without the 's).
4. Click on Save button and an error window pops up saying

"Format Not Supported -- Kig
Kig does not support saving to any other file format than its own. Save to Kig's format instead?"

5. I click on the button that is labeled "Save Kig Format" in the error window and I am dropped back to the file window.

6. I click on Save and the error repeats.

OBSERVED RESULT

The error repeats no matter how I try to save the file unless I manually add the correct file extension (in this case .kig) There is no way to save a file unless the file extension is added manually. Neither Kig or the file window creates the file extension automatically.

EXPECTED RESULT

The file will be saved with the correct extension added automatically.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: Fedora 29 Kig Version v1.0
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: KDE Frameworks 5.54.0
Qt Version: Qt 5.11.3 (built against 5.11.3)

ADDITIONAL INFORMATION
The xcb windowing system
Comment 1 David E. Narvaez 2019-12-22 22:28:09 UTC 
I have posted a patch for review[0] which will add the .kig extension when you click on "Save Kig Format", but my real concern here is: don't you have a checkbox to add the .kig extension automatically? It should have taken care of the extension and saved it in the right format the first try.

[0] https://phabricator.kde.org/D26165
Comment 2 David E. Narvaez 2019-12-23 16:49:15 UTC 
Git commit b2967c9feee3ce0a06c65d353df39bcac0b51ee1 by David E. Narváez.
Committed on 23/12/2019 at 16:49.
Pushed by narvaez into branch 'release/19.12'.

Add Extension to Filename to Save to Kig Format

Summary:
If the user chose to save in Kig format, then just add the extension
as there is no other way to save it.

Test Plan:
1) Save without extension (might need to disable the "Add .kig extension" box).
2) In the error dialog, select "Save Kig Format".
3) Filename should now have the .kig extension.
4) Repeat, but this time trying to save with a different extension than .kig.

Reviewers: #kde_edu, yurchor

Reviewed By: yurchor

Subscribers: yurchor, kde-edu

Tags: #kde_edu

Differential Revision: https://phabricator.kde.org/D26165

M  +19   -1    kig/kig_part.cpp

https://commits.kde.org/kig/b2967c9feee3ce0a06c65d353df39bcac0b51ee1
Comment 3 David E. Narvaez 2019-12-27 20:58:34 UTC 
I will close this as fixed for now, but if the answer to my question in Comment #1 is "no", then we probably have a different issue and this should be reopened.