Summary: | Choosing "offline" status does not disconnect accounts | ||
---|---|---|---|
Product: | [Unmaintained] telepathy | Reporter: | Alexander Blinne <alexander> |
Component: | contactlist | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | akulichalexander, kde |
Priority: | NOR | ||
Version: | git-latest | ||
Target Milestone: | Future | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/ktp-contact-list/6dcdbdc872c2d8fb8e7838dcf5880c5b27b93c47 | Version Fixed In: | 18.12.3 |
Sentry Crash Report: |
Description
Alexander Blinne
2019-02-14 15:41:48 UTC
Same here. The patch looks good and the original code looks weird. The return on ((index == count() - 3) introduced by https://git.reviewboard.kde.org/r/130189/ What is the reason for the extra condition? (David, James?) Yeah, that condition makes no sense. Even if it did, that's a terrible way to code it with just arbitrary indexes. (In reply to Alexander Blinne from comment #0) > Patch at https://phabricator.kde.org/differential/diff/51686/ fixes it most > of the time, though in some cases (10-20% of times) it will go offline and > go back online immediately afterwards. I can't find the reason for this > right now... I applied your patch and the Presence starts to work but it seems that there is some race-condition so if I switch to online and quickly go back to offline before a Connection Manager connected then it has some chance to report "I'm connected" before it was told to stop trying. Would you mind to submit the fix? This patch is a definitely the right thing to do even if the issue still reproducible. There is no other way to fix it and I'm hitting the issue on my own so I would like to have your fix in 18.12.3 and we have literally one day to do that as the release tag will be made at the Monday. If you can't submit the patch today then I would like to commit it with you as the author and me as a committer. (In reply to Alexandr Akulich from comment #3) > If you can't submit the patch today then I would like to commit it with you > as the author and me as a committer. I don't think I can submit the patch as I don't have a developer account, am I right? I don't have much experience with the KDE workflow, unfortunately... Git commit 6dcdbdc872c2d8fb8e7838dcf5880c5b27b93c47 by Alexander Akulich, on behalf of Alexander Blinne. Committed on 03/03/2019 at 22:43. Pushed by akulichalexandr into branch 'Applications/18.12'. Restore the "Offline" option in presence combobox There is no valid reason to show the option but do nothing on activated. Reviewed By: akulichalexander M +1 -1 global-presence-chooser.cpp https://commits.kde.org/ktp-contact-list/6dcdbdc872c2d8fb8e7838dcf5880c5b27b93c47 |