Bug 404277

Summary:	timeline refactor 2019-02-13_Composition causes UI crash
Product:	[Applications] kdenlive	Reporter:	Evert Vorster <evorster>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fritzibaby
Priority:	NOR	Flags:	fritzibaby: timeline_corruption+
Version First Reported In:	Appimage - Refactoring
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/kde/kdenlive/commit/0b6846c9af6ee0999b08e3aeb58cb0d350dce189	Version Fixed/Implemented In:
Sentry Crash Report:

Description Evert Vorster 2019-02-13 06:23:51 UTC

SUMMARY


STEPS TO REPRODUCE
1. Add clips to project.
2. Add clips from project to timeline. (usually there used to be automatic transitions/compositions added here, gone now, as is the hotspot on the clip where one could just add an affine or such with a single click)
3. Manually add composition to timeline
4. Click on compostion properties
5. Add keyframe



OBSERVED RESULT
User Interface freeze

EXPECTED RESULT
Keyframe?

SOFTWARE/OS VERSIONS
Arch Linux, fully up to date as per 2019-02-13

Comment 1 emohr 2019-02-13 19:53:13 UTC

Hi Evert. Thanks for testing and posting. I can confirm this freeze with AppImage #82. Created issue #37: https://invent.kde.org/kde/kdenlive/issues/37. 

Step 2: yes this green hotspot is gone. I put it on the to-do list to re-implement the “1click transition is missing” again.

Comment 2 Jean-Baptiste Mardelle 2019-02-15 10:45:34 UTC

Git commit 0b6846c9af6ee0999b08e3aeb58cb0d350dce189 by Jean-Baptiste Mardelle.
Committed on 15/02/2019 at 10:45.
Pushed by mardelle into branch 'refactoring_timeline'.

Fix freeze on add keyframe. Fixes #37

M  +2    -3    src/assets/keyframes/model/keyframemodel.cpp
M  +1    -1    src/assets/model/assetparametermodel.cpp

https://invent.kde.org/kde/kdenlive/commit/0b6846c9af6ee0999b08e3aeb58cb0d350dce189

Comment 3 Evert Vorster 2019-02-17 05:19:23 UTC

Completely fixed, thanks