Bug 404169

Summary:	Pasting scrolls back up
Product:	[Applications] lokalize	Reporter:	Adrián Chaves (Gallaecio) <adrian>
Component:	editor	Assignee:	Simon Depiets <sdepiets>
Status:	RESOLVED FIXED
Severity:	minor	CC:	shafff
Priority:	NOR
Version:	18.12.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/lokalize/6c6f78e8948687b440f379eefae8a7af53709b00	Version Fixed In:
Sentry Crash Report:

Description Adrián Chaves (Gallaecio) 2019-02-10 09:38:51 UTC

When you paste something on the translation field, the field scrolls up.

It should remain on the same scrolling position.

It can be reproduced with any string long enough to require scrolling, and the longer the string the more annoying it can be.

Comment 1 Simon Depiets 2019-03-19 09:42:56 UTC

Git commit 53bc45aeddf3e9af0265cb1b502b2571c0afcd71 by Simon Depiets.
Committed on 19/03/2019 at 09:40.
Pushed by sdepiets into branch 'master'.

Ensure the cursor is visible after a text operation
Related: bug 403131, bug 405008

M  +4    -9    src/catalog/catalog.cpp
M  +4    -8    src/catalog/gettext/gettextstorage.cpp
M  +2    -4    src/catalog/ts/tsstorage.cpp
M  +2    -4    src/catalog/xliff/xliffstorage.cpp
M  +1    -1    src/common/flowlayout.h
M  +1    -1    src/editorview.cpp
M  +1    -3    src/lokalizemainwindow.cpp
M  +1    -1    src/mergemode/mergecatalog.cpp
M  +14   -9    src/xlifftextedit.cpp
M  +1    -0    src/xlifftextedit.h

https://commits.kde.org/lokalize/53bc45aeddf3e9af0265cb1b502b2571c0afcd71

Comment 2 Simon Depiets 2019-03-19 09:57:43 UTC

I've made some changes to the scrolling mecanism to ensure the cursor is visible, it actually depends if your source string is coming from Lokalize or outside lokalize (there might be unneeded scrolling if you paste from lokalize, but the cursor should still be visible). Could you have a look ?

Comment 3 Simon Depiets 2019-03-21 02:16:55 UTC

Git commit 6c6f78e8948687b440f379eefae8a7af53709b00 by Simon Depiets.
Committed on 19/03/2019 at 13:35.
Pushed by sdepiets into branch 'Applications/19.04'.

Ensure the cursor is visible after a text operation
Related: bug 403131, bug 405008

M  +4    -9    src/catalog/catalog.cpp
M  +4    -8    src/catalog/gettext/gettextstorage.cpp
M  +2    -4    src/catalog/ts/tsstorage.cpp
M  +2    -4    src/catalog/xliff/xliffstorage.cpp
M  +1    -1    src/common/flowlayout.h
M  +1    -1    src/editorview.cpp
M  +1    -3    src/lokalizemainwindow.cpp
M  +1    -1    src/mergemode/mergecatalog.cpp
M  +14   -9    src/xlifftextedit.cpp
M  +1    -0    src/xlifftextedit.h

https://commits.kde.org/lokalize/6c6f78e8948687b440f379eefae8a7af53709b00