Bug 404168

Summary:	applyTheme` can have a wrong value in some cases
Product:	[Plasma] lattedock	Reporter:	trmdi
Component:	application	Assignee:	Michail Vourlakos <mvourlakos>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	git (master)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/latte-dock/669957a15649a7c6baf168cf9d8735c5c60acca4	Version Fixed In:

Description trmdi 2019-02-10 09:16:37 UTC

STEPS TO REPRODUCE
1. Use material-blur plasma theme (which has a dark background)
2. Use this wallpaper: https://whvn.cc/711820
2. Color & Background settings of Latte: https://i.imgur.com/32ciWNq.png

OBSERVED RESULT
White color is used for Latte view.
Screenshot: https://i.imgur.com/uBU09Nn.png

EXPECTED RESULT
Black color should be used.

Comment 1 Michail Vourlakos 2019-02-10 09:31:05 UTC

Git commit 669957a15649a7c6baf168cf9d8735c5c60acca4 by Michail Vourlakos.
Committed on 10/02/2019 at 09:30.
Pushed by mvourlakos into branch 'master'.

respect popup settings both for Smart and Reverse

M  +5    -5    containment/package/contents/ui/colorizer/Manager.qml

https://commits.kde.org/latte-dock/669957a15649a7c6baf168cf9d8735c5c60acca4

Comment 2 Michail Vourlakos 2019-02-10 09:31:30 UTC

ok found it..
the fix should be also applied for Smart mode theme...

Comment 3 trmdi 2019-02-10 10:37:56 UTC

Nice.

Is there any case that `root.userShowPanelBackground == false` in this line ?
https://cgit.kde.org/latte-dock.git/tree/containment/package/contents/ui/colorizer/Manager.qml?id=669957a15649a7c6baf168cf9d8735c5c60acca4#n59

- If it's always `true`: Why do you have to check it ?
- If it could be `false` in some cases: that code block will not run -> this bug hasn't been fixed completely.

Comment 4 Michail Vourlakos 2019-02-10 10:46:02 UTC

The userShowPanelBackground is true when the user has activated the Background section in options and false otherwise.

Feel free to provide cases that current implementation breaks

Comment 5 trmdi 2019-02-10 11:01:17 UTC

(In reply to Michail Vourlakos from comment #4)
> The userShowPanelBackground is true when the user has activated the
> Background section in options and false otherwise.

If it is the ONLY case that `userShowPanelBackground == false` then it seems ok now.
Thank you!