| Summary: | Tabbox kcm incorrectly falls back to informative on broken theme | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Chris Holland <zrenfire> |
| Component: | tabbox | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, isma.af, johnnyl33 |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/3ca1fc800d7f7d8b36a3ec5436f644439c6f0146 | Version Fixed/Implemented In: | 6.0 |
| Sentry Crash Report: | |||
|
Description
Chris Holland
2019-02-09 19:21:37 UTC
This means the kcm is wrong - I reworded the title accordingly. The informative theme is not part of KWin (any more) and not installed by default in most distributions. Using it as fallback is an obvious oversight. The main reason I made this bug is for when a downloaded QML skin from the KDE Store is loaded but fails to load (eg: was written for KWin 4.x). However, you do raise a good point, I completely forgot "informative" is part of kdeplasma-addons. So it seems the hardcoded default needs to be... "org.kde.breath.desktop" so that it loads: /usr/share/plasma/look-and-feel/org.kde.breath.desktop/contents/windowswitcher/WindowSwitcher.qml However that still depends on the breeze package. KWin itself does not seem to ship with any "QML" tabbox skins that I can see. So does this mean it needs to somehow fallback to a C++ TabBox theme? Like the "kwin/effects/coverswitch" desktop effect? I'm not quite sure how it loads the C++ effects to be honest... Looking at the kcm code, it seems that the desktop effect itself has a "TabBox" config property. I take it that it will then take over the "Alt+Tab" and "Alt+Shift+Tab" shortcuts. * https://github.com/KDE/kwin/blob/cfecb1e0770ca6c8fa879124e11b03081342b9ed/kcmkwin/kwintabbox/main.cpp#L368 * https://github.com/KDE/kwin/blob/master/effects/coverswitch/coverswitch.kcfg#L35 * Falling back to a "kwin effect" skin sounds like a fairly complicated fallback, as you'd need to copy the kcm's save() code. Well the fallback will have to be removed. This got solved by including back the fallback theme into kwin repository https://invent.kde.org/plasma/kwin/-/commit/3ca1fc800d7f7d8b36a3ec5436f644439c6f0146 |