| Summary: | Wizard (all pages) back button is not left-aligned | ||
|---|---|---|---|
| Product: | [Unmaintained] ring-kde | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Emmanuel Lepage Vallée <emmanuel.lepage> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Back button not left-aligned | ||
Still a problem. Technically it's because the Kirigami handle tends to move in that spot without prior notification and I mitigated the issue by adding that space. 1. That's not a great solution to the problem 2. even when where's no left drawer and no drawer handle, the back button is still moved over to the right Oh, don't take it like that. That's a real bug, I am not arguing it, I was just referring why that weird space was added. In previous version of Kirigami, the handle was always there, you could not press back button without this space. On newer version it's moving around with no way to prevent it. Yes, you can force the toolbar **on the desktop mode**, but the `pageStack.globalToolBar.style` is ignored on mobile, so it isn't a solution either. It needs a proper fix and a proper way to detect when the space is necessary and when it is not. IMHO there should be a way to block the handle from getting there. A chat app is "naturally" bottom heavy and those controls get in the way (be it the main action button or the handle). For the Android APK, I had to delete the code from Kirigami for anything but the global toolbar because it was adding buttons on top of the chatbox. I mean, it's a real problem for Banji, the wizard button offset is just the tip of the iceberg. I understand the reason why Kirigami is bottom heavy and why it tries to fight you when you try to force the control to be at the top. However it really doesn't work in this case. It seems like a better solution would be to remove or disable the left drawer while you're in the wizard, and then there will be no drawer handle on the bottom in the first place. There is no reason to have the drawer accessible while the user is doing the wizard. > There is no reason to have the drawer accessible while the user is doing the wizard.
To quit? (assuming quit is fixed)
If you're on the desktop, you quit by clicking in the titlebar's close button or using a keyboard shortcut. On mobile, you leave the app use the operating system's always visible back or home button, and quit by some other OS-specific method. This has been fixed in Kirigami (new feature to disable bottom heavyness on Android for already bottom heavy apps). The new feature is now used in Banji. |
Created attachment 117893 [details] Back button not left-aligned On all pages of the wizard, the back button on the bottom is not aligned to the left screen/window edge. There's an awkwardly large amount of padding between it and the edge instead.