Bug 403924

Summary:	Use an eyedropper icon for the color-picker* icons
Product:	[Plasma] Breeze	Reporter:	farid <snd.noise>
Component:	Icons	Assignee:	visual-design
Status:	RESOLVED FIXED
Severity:	normal	CC:	kainz.a, laakkonenc, nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=399665
Latest Commit:	https://commits.kde.org/breeze-icons/b9dd7fd5a67220f5accc0ba1f6764f047f352ec3	Version Fixed In:	5.65
Sentry Crash Report:

Description farid 2019-02-04 14:09:03 UTC

SUMMARY
Switch the icon of the eye dropper to something more intuitive and even easier to select colors with.

I like something like this:
https://github.com/KDE/krita/blob/46c8b4048fc7f5b81a4128bc4dcaf1568d3cf316/krita/data/cursors/color-picker_image_foreground.xpm

Comment 1 Calle Laakkonen 2019-11-03 08:32:33 UTC

I'm using Breeze icons in my application and have a replacement icon for the color picker contributed by a user:

Icon: https://github.com/drawpile/Drawpile/blob/master/desktop/theme/light/color-picker.svg
Related issue tracker link: https://github.com/drawpile/Drawpile/issues/540

Comment 2 Nate Graham 2019-11-03 18:36:24 UTC

Very cool! Can I get your permission to use that icon as the basis for fixing this bug?

Comment 3 Calle Laakkonen 2019-11-03 18:47:51 UTC

Yes, be my guest. The original author (Le2222 @ github) also granted permission.

Comment 4 Nate Graham 2019-11-03 19:40:28 UTC

Thanks! I've submitted a patch upstream: https://phabricator.kde.org/D25132

BTW I re-did a bunch of the other Breeze draw-* and select-* icons in https://cgit.kde.org/breeze-icons.git/commit/?id=96642fc58f98f89fbea0ea7525ca45e0e807cc6d, so if you've forked the theme or are using hardcodedc copies of those icons, you might want to update your versions (and also consider using the icons directly from the theme rather than embedding them in your app :) )

Comment 5 Calle Laakkonen 2019-11-03 19:45:32 UTC

Thanks, I probably should indeed update my copy of the theme. I am actually using the system theme. The copies are used only as fallbacks if an icon is not found in the theme.

Comment 6 Nate Graham 2019-11-13 21:27:40 UTC

Git commit b9dd7fd5a67220f5accc0ba1f6764f047f352ec3 by Nate Graham.
Committed on 13/11/2019 at 21:27.
Pushed by ngraham into branch 'master'.

Use an eyedropper for color-picker icons

Summary:
The current icon is a black droplet which doesn't really communicate "pick a color from
the screen", though that's what this icon is used for. Other apps use an eyedropper for
this too.

This icon is a modification of one submitted in https://bugs.kde.org/show_bug.cgi?id=403924.
I've cleaned it up to pixel-align everything, use the correct margins, and do the CSS stylesheet
magic.
FIXED-IN: 5.65

Test Plan:
Montage: {F7761511, size=full}
In Kolourpaint: {F7761515, size=full}

Reviewers: #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25132

M  +11   -12   icons-dark/actions/16/color-picker.svg
M  +12   -14   icons-dark/actions/22/color-picker.svg
M  +11   -12   icons-dark/actions/24/color-picker.svg
M  +11   -12   icons-dark/actions/32/color-picker.svg
M  +11   -12   icons/actions/16/color-picker.svg
M  +12   -14   icons/actions/22/color-picker.svg
M  +11   -12   icons/actions/24/color-picker.svg
M  +11   -12   icons/actions/32/color-picker.svg

https://commits.kde.org/breeze-icons/b9dd7fd5a67220f5accc0ba1f6764f047f352ec3