Bug 403880

I don't see the need of this option.

(In reply to trmdi from comment #1)
> I don't see the need of this option.

The only way to set the shortcuts for items of the "Latte Plasmoid" widget is in SystemSetting > Shortcut.  "Activate based on position through global shortcuts" should only be used for Latte Plasmoid.

For other widgets, users should/could set the shortcut through the Configure widget > Keyboard.

(In reply to trmdi from comment #2)
> (In reply to trmdi from comment #1)
> For other widgets, users should/could set the shortcut through the Configure
> widget > Keyboard.

they still can. This is a feature, users wanted for convenience to be able to activate applets also through "global shortcuts based on position" feature, not just the taskmanager entries.

The thing is that I am struggling to follow "easy to find, simple to understand" for all "global shortcuts based on position" options. I have the following in my though.

Feature "global shortcuts based on position":
[1] - should have a way to be enabled/disabled
[2] - should have a way for the user to choose which of the panels/docks presented to him is going to be used
[3] - should have a way to be used both for applets/tasks OR only for tasks

Solutions:
[1] - does not exist yet, I am thinking that this could be identified easily based to global shortcuts tracking. If the user has not enabled global shortcuts to activating Latte entries for positions 1 and 2 then that would mean that the feature is not enabled
[2] - this is currently Behavior->"Activate based on position through global shortcuts". Maybe it should be renamed to "Prefer for global shortcuts based on position"
[3] - this is currently Tasks->Activate based on position shortcuts only for tasks"


I suppose you propose [3] to be default, that is not a problem.
What do you think? I dont want to lose features just to make [1]-[3] "easy to find, simple to understand"

Ah, I did't relize that there are 2 options:
- Behavior->"Activate based on position through global shortcuts"
- Tasks->Activate based on position shortcuts only for tasks"

> I suppose you propose [3] to be default, that is not a problem.
Yes, I meant that. :)

But I think, currently, these "Activate based on position through global shortcuts" options are very confusing. We should make it easier to understand.

Git commit cf93b7516d9ceaa84d3744e08194211967a098a3 by Michail Vourlakos.
Committed on 03/02/2019 at 07:55.
Pushed by mvourlakos into branch 'master'.

improve global shortcuts options

--the user can disable "global shortcuts based
on position" by disabling the global shortcuts
for the first two latte items
--improve texts readability

M  +23   -17   app/shortcuts/globalshortcuts.cpp
M  +13   -1    app/shortcuts/shortcutstracker.cpp
M  +6    -1    app/shortcuts/shortcutstracker.h
M  +3    -0    app/view/settings/primaryconfigview.cpp
M  +2    -2    containment/package/contents/config/main.xml
M  +13   -12   shell/package/contents/configuration/pages/BehaviorConfig.qml
M  +3    -3    shell/package/contents/configuration/pages/TasksConfig.qml

https://commits.kde.org/latte-dock/cf93b7516d9ceaa84d3744e08194211967a098a3

(In reply to trmdi from comment #4)
> Ah, I did't relize that there are 2 options:
> > I suppose you propose [3] to be default, that is not a problem.
> Yes, I meant that. :)

that last commit provides [1]-[2], unfortunately for [3] I just realized I can not change the default because in that case if there is not a Tasks plasmoid in the latte view then the user can not activate the "Global shortcuts based on position" feature.

> "Activate based on position through global shortcuts" options are very confusing.

I changed them a bit in the last commit, if you can think something better enlighten me... :)

> [1] - should have a way to be enabled/disabled
Why should there be such an option?

> [2] - this is currently Behavior->"Activate based on position through global shortcuts". Maybe it should be renamed to "Prefer for global shortcuts based on position"

Its name could be: "Use Latte entries of global shorcuts for this dock/panel"
(You shouldn't use the "view" word like what you're doing in the tooltip text, it's too abstract, it should be "this panel/dock", depends on the view type)
(My proposal tooltip: "Latte entries can be found in SystemSettings > Shortcut > Latte" )


> [3] Tasks->Activate based on position shortcuts only for tasks"
should be renamed to: "Use Latte entries of global shortcuts only for tasks"

(In reply to Michail Vourlakos from comment #7)
> (In reply to trmdi from comment #4)
> > Ah, I did't relize that there are 2 options:
> > > I suppose you propose [3] to be default, that is not a problem.
> > Yes, I meant that. :)
> 
> that last commit provides [1]-[2], unfortunately for [3] I just realized I
> can not change the default because in that case if there is not a Tasks
> plasmoid in the latte view then the user can not activate the "Global
> shortcuts based on position" feature.

I meant the default should be like this:

- [2] Behavior->"Activate based on position through global shortcuts"-> enabled for the first view that has Latte Plasmoid
- [3] it should be off.

(In reply to trmdi from comment #9)
> I meant the default should be like this:
> 
> - [2] Behavior->"Activate based on position through global shortcuts"->
> enabled for the first view that has Latte Plasmoid

If there is not any view that has Latte Plasmoid -> enable it for the first view Latte knows.

But I think almost all users use Latte dock with Latte Plasmoid, so 99% there would be a view that has Latte Plasmoid on it.

> [1] - should have a way to be enabled/disabled

Isn't it disabled when the user doesn't check [2] on any view?

(In reply to trmdi from comment #11)
> > [1] - should have a way to be enabled/disabled
> 
> Isn't it disabled when the user doesn't check [2] on any view?

no, that option is used only to determine which view has the highest priority for global shortcuts based on position

(In reply to Michail Vourlakos from comment #12)
> (In reply to trmdi from comment #11)
> > > [1] - should have a way to be enabled/disabled
> > 
> > Isn't it disabled when the user doesn't check [2] on any view?
> 
> no, that option is used only to determine which view has the highest
> priority for global shortcuts based on position

Hmm, I thought that feature can be used for ONLY ONE view?
> This view activates its items based on their position through global shortcuts. Take note that only one view can have that option enabled for each layout

It means, if that only view has that option unchecked, this feature is disabled.

(In reply to trmdi from comment #13)
> (In reply to Michail Vourlakos from comment #12)
> > (In reply to trmdi from comment #11)
> It means, if that only view has that option unchecked, this feature is
> disabled.

this isnt the case, if that only view has that option unchecked, the feature is still enabled because when there is no view that has that option enabled then the priority is considered based on the view location...

Primary Screen -> Bottom,Left,Top,Right
Explicit Screen -> Bottom,Left,Top,Right
etc.

Do you have a better description for the feature?

(In reply to Michail Vourlakos from comment #14)
> (In reply to trmdi from comment #13)
> > (In reply to Michail Vourlakos from comment #12)
> > > (In reply to trmdi from comment #11)
> > It means, if that only view has that option unchecked, this feature is
> > disabled.
> 
> this isnt the case, if that only view has that option unchecked, the feature
> is still enabled because when there is no view that has that option enabled
> then the priority is considered based on the view location...
> 
> Primary Screen -> Bottom,Left,Top,Right
> Explicit Screen -> Bottom,Left,Top,Right
> etc.
> 

Wait...
On my layout (1 top panel, 1 bottom dock), when I uncheck both Behavior->"Activate based on position through global shortcuts"

The feature is disabled. I can't use Latte entries of global shortcuts for my bottom dock.
It does not "priority is considered based on the view location..."  as you said above.
Is it a bug?

-----

What do you think if the feature works like this:
- No view has "Behavior->Activate based on position through global shortcuts" checked -> disabled
- One (and only one) view has the above option checked: -> enabled on that view
- Default: enabled on the first view that has Latte Plasmoid or based on the view location... (*)

Why do you want "the feature is still enabled because when there is no view that has that option enabled then the priority is considered based on the view location..." ? (**)

I think you can remove (**) because:
- The default behavior (*) is good enough. It covers the (**) behavior.
- When the user uncheck that default checkbox -> he turns off the feature.
- If he wants to use global shortcuts on a specific view -> check on the Behavior option.

What use case that my proposal can not do?

(In reply to trmdi from comment #15)
> (In reply to Michail Vourlakos from comment #14)
> > (In reply to trmdi from comment #13)
> > > (In reply to Michail Vourlakos from comment #12)
> > > > (In reply to trmdi from comment #11)
> 
> Wait...
> On my layout (1 top panel, 1 bottom dock), when I uncheck both
> Behavior->"Activate based on position through global shortcuts"
> 
> The feature is disabled. I can't use Latte entries of global shortcuts for
> my bottom dock.
> It does not "priority is considered based on the view location..."  as you
> said above.
> Is it a bug?
> 

yes, you need to update, I fixed it this morning


> -----
> 
> What do you think if the feature works like this:
> - Default: enabled on the first view that has Latte Plasmoid or based on the
> view location... (*)

unfortunately this is messy... Having options that are changed through time means that Latte should also track when that option was changed by the user in order to not change it back again. Simpler would be to be disabled for all views at first time until the user just enables the feature for one of the views.

> 
> Why do you want "the feature is still enabled because when there is no view
> that has that option enabled then the priority is considered based on the
> view location..." ? (**)
> 

It may is not needed if we follow the road that "If no view has that option enabled then global shortcuts based on position are not enabled also"

> 
> What use case that my proposal can not do?

The proposed Default is difficult to support, what do you think if we disable "Activate based on position through global shortcuts" for all views and wait until the user enables it for one of them?


Cons:
In order to activate "Global Shortcuts based on position" the following should be valid:
1. The global shortcuts for Activate Entry 1 and 2 must be enabled from plasma systemsettings
2. The "Activate based on position through global shortcuts"(Behavior) must be enabled to work for applets
3. The "Based on position shortcuts apply only to tasks"(Tasks) must be enabled in order to work ONLY for tasks

[2] needs [1] to be active
[3] needs both [1] and [2] to be active


the fact that [3] is in tab Tasks and is going to be disabled when [2] is not active concerns me a bit...

1, I like follow the road that "If no view has that option enabled then global shortcuts based on position are not enabled also".

2, I like to remove this condition:
> 1. The global shortcuts for Activate Entry 1 and 2 must be enabled from plasma systemsettings

3, We should find a way to enable it on some view by default.

I don't understand why this would be a problem?

> unfortunately this is messy... Having options that are changed through time means that Latte should also track when that option was changed by the user in order to not change it back again.

(In reply to trmdi from comment #17)
> 1, I like follow the road that "If no view has that option enabled then
> global shortcuts based on position are not enabled also".
>

ok
 
> 2, I like to remove this condition:
> > 1. The global shortcuts for Activate Entry 1 and 2 must be enabled from plasma systemsettings
>
 
ok

> 3, We should find a way to enable it on some view by default.
> 
> I don't understand why this would be a problem?
> 

I cant think of any implementation that does not add too much complexity, feel free to prove me wrong after two above ok are landed

Git commit c1bcd5c5ca5dc040f5afd287e3dcee7df8f990db by Michail Vourlakos.
Committed on 03/02/2019 at 16:50.
Pushed by mvourlakos into branch 'master'.

improvements for global shortcuts based on position

M  +18   -17   app/shortcuts/globalshortcuts.cpp
M  +13   -13   shell/package/contents/configuration/pages/BehaviorConfig.qml
M  +1    -1    shell/package/contents/configuration/pages/TasksConfig.qml

https://commits.kde.org/latte-dock/c1bcd5c5ca5dc040f5afd287e3dcee7df8f990db

(In reply to Michail Vourlakos from comment #18)
> (In reply to trmdi from comment #17)

ok I merged the improvements feel free to play with the Default

(In reply to Michail Vourlakos from comment #18) 
> > 3, We should find a way to enable it on some view by default.
> > 
> > I don't understand why this would be a problem?
> > 
> 
> I cant think of any implementation that does not add too much complexity,
> feel free to prove me wrong after two above ok are landed

I sent you a patch: https://phabricator.kde.org/D18717

Git commit fede9feb2dd032fe18a68e62dc420265544fc768 by Michail Vourlakos, on behalf of Tranter Madi.
Committed on 06/02/2019 at 16:17.
Pushed by mvourlakos into branch 'master'.

improvements for global shortcuts

Summary: BUG: 403880

Reviewers: mvourlakos

Reviewed By: mvourlakos

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18717

M  +18   -0    app/layout/layout.cpp
M  +7    -0    app/layout/layout.h
M  +12   -2    app/shortcuts/globalshortcuts.cpp
M  +2    -1    app/shortcuts/globalshortcuts.h
M  +9    -0    app/view/view.cpp
M  +3    -0    app/view/view.h
M  +4    -1    shell/package/contents/configuration/pages/BehaviorConfig.qml
M  +1    -1    shell/package/contents/configuration/pages/TasksConfig.qml

https://commits.kde.org/latte-dock/fede9feb2dd032fe18a68e62dc420265544fc768