| Summary: | Redundant warning on close for unmodified documents in multiple tabs view | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | happy <hh.kde.crash> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | minor | CC: | aacid, m.weghorn, nate, yurchor |
| Priority: | NOR | ||
| Version First Reported In: | 1.4.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
happy
2019-02-02 07:29:48 UTC
This warning can be useful because sometimes you can unintentionally close the window trying to close the current document only. (In reply to happy from comment #0) > ADDITIONAL INFORMATION > Minor (for me) because I don't often do markup and I can just uncheck "warn > me if closing multiple tabs"; but if modifying documents was part of your > work flow then this would be more severe (ie: false warnings obscuring real > ones) Can you explain what exactly you mean by this? A quick test for me showed that when unchecking "warn me if closing multiple tabs", * no dialog appears when closing multiple unmodified documents (as you want it to be) * a dialog "Do you want to save your changes to <FILE> or discard them?" still appears if any of the documents was modified (e.g. an annotation was added) This is what I would have expected and what I'd consider to be the "correct" behaviour. Can you describe what should be different in your eyes? (In reply to Yuri Chornoivan from comment #1) > This warning can be useful because sometimes you can unintentionally close > the window trying to close the current document only. Yes, I totally agree, I do that all the time (it's the downside of tabs). What the bug report is about is about is QUITTING Okular, particularly when done automatically on session log out. I'm sorry I used the word "CLOSING". I always use "Restore Previous Session" type logins; so I always (well, for most applications) get all my windows back anyway. As I said, it's a problem if something hangs up the machine shutting down... particularly when there's no need. > This is what I would have expected and what I'd consider to be the "correct"
> behaviour. Can you describe what should be different in your eyes?
Thank you for trying that, I didn't try markup. See my reply to Yuri about clarification.
I guess I'm requesting a third behaviour on quitting the application?
IE: with the "warn me" behaviour unsuppressed, so that closing a window will generate warnings that _quitting_ the application won't ?
(eg: EXACTLY the same behaviour as Firefox)
I'm going to suggest you close this bug and start a new one with a subject that clearly mentions logging out. I'm not sure I see what the bug is. What Michael describes is exactly what I see too and what I would expect. If you don't like the "close multiple tabs" warning, you can just uncheck the checkbox and never see them again, but still see the warning when quitting/logging off when modified documents have not been saved. Can you explain what it is that you expect to happen? Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |