Bug 403807

Summary: Ditch the "make primary actions button-like" visual style
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Nate Graham <nate>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/kirigami/a62626ab23a4aea17d9538662302678b9dd8b50d Version Fixed/Implemented In: 5.55
Sentry Crash Report:

Description Nate Graham 2019-01-31 17:28:03 UTC 
Right now, when an action is marked as a primary action, on the desktop its toolbar icon gains a buttonlike appearance. This is visually problematicfor the following reasons:

- When there are other actions too, they don't have a buttonlike appearance, so the toolbar buttons have an inconsistent appearance that could make some people think that the non-primary-actions aren't actually clickable buttons
- No toolbars in other KDE software look like this; it's inconsistent with the rest of our software

I recommend going back to having primary actions use the same visual style as all other toolbar buttons, and rely on their central position to denote that they're the primary action.

For custom-colored buttons, we can keep the buttonlike appearance just so there's a background that we can color.
Comment 1 Marco Martin 2019-01-31 17:50:11 UTC 
Git commit a62626ab23a4aea17d9538662302678b9dd8b50d by Marco Martin.
Committed on 31/01/2019 at 17:49.
Pushed by mart into branch 'master'.

raise only colored buttons

M  +2    -2    src/controls/private/PrivateActionToolButton.qml
M  +0    -1    src/controls/private/globaltoolbar/ToolBarPageHeader.qml

https://commits.kde.org/kirigami/a62626ab23a4aea17d9538662302678b9dd8b50d
Comment 2 Nate Graham 2019-01-31 18:06:24 UTC 
Wow, that was fast. Thanks Marco!