| Summary: | Some comboboxes don't show all items | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-qqc2-desktop-style | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/qqc2-desktop-style/152bb7363a803a8099367cc7f423b9b8180f0ba4 | Version Fixed In: | 5.55 |
|
Description
Nate Graham
2019-01-29 15:31:48 UTC
Git commit 152bb7363a803a8099367cc7f423b9b8180f0ba4 by David Edmundson. Committed on 30/01/2019 at 01:55. Pushed by davidedmundson into branch 'master'. Fix combobox initial sizing Summary: We have a listview in a popup. The popup is resized to the listview content height. Because the popup starts out at size 0 the listview thinks it's too small to show anything. So it doesn't load any delegates. As it has no delegates it can't guess the contentHeight. contentHeight is a guess based on count * (currentHeight / currentlyLoadedDelegates) That means the popup doesn't resize properly. Ultimately it does end up showing a two entries, but it doesn't re-evaluate the contentHeight properly to resize the popup correctly. Forcing it to load one delegate is enough to break that cycle. Test Plan: Opened popup in cursortheme and fonts Worked correctly Reviewers: #plasma, mart, ngraham Reviewed By: #plasma, mart, ngraham Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D18597 M +5 -0 org.kde.desktop/ComboBox.qml https://commits.kde.org/qqc2-desktop-style/152bb7363a803a8099367cc7f423b9b8180f0ba4 |