Bug 403711

Summary:	Navigation by keyboard is not clear or reliable
Product:	[Applications] Discover	Reporter:	Alexander Mentyu <notuxius>
Component:	discover	Assignee:	Aleix Pol <aleixpol>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR
Version:	5.14.90
Target Milestone:	---
Platform:	Neon
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=407524
Latest Commit:	https://commits.kde.org/kirigami/56cb2c2b14c2f3853561416abc1d2136a04edd6c	Version Fixed In:	5.59
Sentry Crash Report:

Description Alexander Mentyu 2019-01-28 20:23:07 UTC

STEPS TO REPRODUCE
For example:
1. Start Discover.
2. Press up/down arrows (featured apps are navigating by keyboard).
3. Select some app.
4. Press up/down arrows.

OBSERVED RESULT
Middle featured apps list isn't navigating by keyboard. Also after Enter key press the currently selected app page isn't showing.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.2
Kernel Version: 4.15.0-42-generic

Comment 1 Nate Graham 2019-02-06 01:15:03 UTC

Yeah, keyboard navigation in the apps lists and between the sidebar and the apps list is not ideal. It's also not clear what's focused.

Comment 2 Aleix Pol 2019-05-10 15:21:19 UTC

https://phabricator.kde.org/D21128

Comment 3 Aleix Pol 2019-05-14 13:09:39 UTC

Git commit 56cb2c2b14c2f3853561416abc1d2136a04edd6c by Aleix Pol.
Committed on 14/05/2019 at 13:09.
Pushed by apol into branch 'master'.

Improve keyboard-only usage of the toolbar

Summary:
Have PrivateActionToolButton trigger its action if the mnemonic is activated.

Test Plan: I can call the actions on the toolbar now (e.g. on Discover application page)

Reviewers: #kirigami, mart

Reviewed By: #kirigami, mart

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D21188

M  +5    -0    src/controls/private/PrivateActionToolButton.qml

https://commits.kde.org/kirigami/56cb2c2b14c2f3853561416abc1d2136a04edd6c

Comment 4 Nate Graham 2019-05-14 14:22:50 UTC

Thanks! BTW wWhile testing this, I ran into Bug 407524.