| Summary: | Slideshow - display the list of images that will be shown | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | David Redondo <kde> |
| Component: | Image & Slideshow wallpaper plugins | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, filipfila.kde, kde, kde, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/2003b267d4bcc6d0d2bee585d9da0c0abde6e85d | Version Fixed In: | 5.16.0 |
| Sentry Crash Report: | |||
| Attachments: |
Mockup of the idea
Current settings |
||
Created attachment 117706 [details]
Current settings
That's quite a good idea. In your head, is the preview list on the right showing the total from /all/ the folders, or showing you what's in the selected folder? My idea was that it shows what's in the selected folder. dermauch in the vdg room/telegram had the idead to have an option to show the images from all folders I love it! What makes sense to me is that the right pane shows all wallpapers from all folders in the left pane, and the items in the left folder pane are not selectable (just deletable). I'm not sure there's much value to showing per-folder wallpapers in the right pane; that would get confusing. >I'm not sure there's much value to showing per-folder wallpapers in the right pane; that would get confusing.
It depends, one thing I'd like to do is back up to the question we should have started with.
What problems does David Redondo have with configuring the slideshow wallpaper right now that we're trying to solve?
I can answer that for my use cases at least. The problem is that there's no clear way to see which wallpapers will be a part of the slideshow. You only see a list of the folders that contain the wallpapers that will be a part of the slideshow, not the actual wallpapers themselves. You need to remember which images are in those folders. That's why I think the right pane should show the union of all wallpapers in all folders: then it would be answering the question of "which images will be included in the slideshow?" If it only showed the images in the selected folders, it wouldn't be answering that question anymore. I think the improvement is that the user sees what images are added to the slideshow. Right now you have to know which images are in which folders because you are adding them blind. Also if you have some pictures you would like in your slideshow and in the same folder you have pictures you don't want to add you have to create a new folder and move them around. Apart from that I think the settings should be visually redesigned because they don't look good in my opinion. >I think the improvement is that the user sees what images are added to the slideshow So the problem was that in order to verify what was added you currently have to sit through a million hours watching it cycle. I'm fully on board with that. >Also if you have some pictures you would like in your slideshow and in the same folder you have pictures you don't want to add you have to create a new folder and move them around. How would that change with the preview list? I had in my mind some sort of icon on each image that you could click on to exclude an image but didn't include it in the mockup because I didn't find a suitable one (a vague idea was open/closed eye). As I wrote in the bug description flipwise suggested checkboxes (apparently like Windows 7 does) (In reply to David Redondo from comment #9) > I had in my mind some sort of icon on each image that you could click on to > exclude an image but didn't include it in the mockup because I didn't find a > suitable one (a vague idea was open/closed eye). As I wrote in the bug > description flipwise suggested checkboxes (apparently like Windows 7 does) Yes, something like this: http://cdn.nirmaltv.com/images/changewallpaper.png Git commit 2003b267d4bcc6d0d2bee585d9da0c0abde6e85d by Nate Graham, on behalf of David Redondo.
Committed on 09/03/2019 at 16:05.
Pushed by ngraham into branch 'master'.
Image Wallpaper Slideshow - display the list of images that will be shown
Summary:
This shows all the pictures inside the folders added to the Folders list. I also tried to make single pictures excludable via a checkbox on the thumbnail. This is the first time for me programming with QT/QML/Singals-Slots and I tried to use as much existing code as possible. The thumbnail view is the same as for single images and I simply subclassed the listmodel. However even if I tried to do everything like the code for slidePaths it doesn't work correctly. The checking/unchecking of images only applies on restart of plasmashell. Maybe it's a single mistake that is easily spotted by a more experienced programmer otherwise if the thumbnail view is accepted I can also revert all the checkbox stuff.
FIXED-IN: 5.16.0
{F6595564}
Reviewers: #vdg, ngraham, davidedmundson
Reviewed By: #vdg, ngraham, davidedmundson
Subscribers: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18809
M +1 -0 wallpapers/image/CMakeLists.txt
M +5 -3 wallpapers/image/backgroundlistmodel.h
M +43 -3 wallpapers/image/image.cpp
M +6 -1 wallpapers/image/image.h
M +5 -5 wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
M +65 -30 wallpapers/image/imagepackage/contents/ui/config.qml
A +44 -0 wallpapers/image/slidemodel.cpp [License: UNKNOWN] *
A +19 -0 wallpapers/image/slidemodel.h [License: UNKNOWN] *
The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.
https://commits.kde.org/plasma-workspace/2003b267d4bcc6d0d2bee585d9da0c0abde6e85d
|
Created attachment 117705 [details] Mockup of the idea Current slideshow settings don't look good and the only functionality is adding a whole folder to the slideshow. My idea is to have a list of folders on the left and an area where the images in the currently selected folder are shown with the possibility to exclude images. For this flipwise proposed checkboxes (missing on the attached image). Another idea from dermauch is to have an option/list item to show all images from all folders or a checkbox list.