Bug 403619

Summary: When opening link with mouse middle button url is not cleaned
Product: [Applications] Falkon Reporter: Juraj <jurajoravec>
Component: generalAssignee: David Rosca <nowrep>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: https://commits.kde.org/falkon/6678a98d91f4daa4ff69acaa62e347d05f34a34f Version Fixed In: 3.1.0
Sentry Crash Report:

Description Juraj 2019-01-26 10:40:31 UTC 
SUMMARY
Hello,
when opening link with not clean URL with mouse middle button, this url is not cleaned which results in mixing the link url with current url.

Example of wring link:
> <a href=" https://kde.org/">My cute link</a>

STEPS TO REPRODUCE
1. Open Falkon, create webpage or go to example site and check links in "Additional info:" section:
   https://bugs.archlinux.org/task/61513?project=1&string=ghostscript
2. Use mouse middle butten to open the link in new tab
3. Observe result

OBSERVED RESULT
Falkon opens new tab with url which containt <current url> + <link url> which in most cases results in loading wrong page.
The url is processed fine when opening with mouse left button or with context menu option "Open link in new tab".

EXPECTED RESULT
Falkon should clean url before opening it.

SOFTWARE/OS VERSIONS
Application version 3.0.99 (0bb78c85)
QtWebEngine version 5.12.0
Comment 1 David Rosca 2019-01-26 11:30:17 UTC 
Git commit 6678a98d91f4daa4ff69acaa62e347d05f34a34f by David Rosca.
Committed on 26/01/2019 at 11:29.
Pushed by drosca into branch 'master'.

WebHitTestResult: Trim value of src/href attributes
FIXED-IN: 3.1.0

M  +3    -3    src/lib/webengine/webhittestresult.cpp

https://commits.kde.org/falkon/6678a98d91f4daa4ff69acaa62e347d05f34a34f