Bug 403525

Summary: "Split" toolbar button toggle behaviour inconsistent with other toolbar toggle buttons
Product: [Applications] dolphin Reporter: danbohea <info>
Component: generalAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal CC: elvis.angelaccio, nate
Priority: NOR    
Version First Reported In: 18.12.1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description danbohea 2019-01-23 09:50:52 UTC
SUMMARY

When clicked, the "Split" toolbar button toggles its label between "Split" and "Close", as well as its icon and background colour. This is inconsistant with other toolbar toggle buttons such as "Hidden Files" and "Terminal" whose labels never change. If you're still familiarising yourself with Dolphin's UI this can be confusing as it requires you to remember what the "Close" button actually closes.

I would suggest that the label simply stays the same ("Split") and that the icon and background colour change be sufficient to indicate that the the split view is indeed active (not to mention the fact that you'll have 2 "split" file browser panes in front of you).

STEPS TO REPRODUCE
1. Open Dolphin.
2. Click the "Split" toolbar button.
3. (time passes while you do work)
4. Scratch head wondering how to revert the split.
5. Eventually figure out that it's the vague "Close" button that you need to click.
Comment 1 Nate Graham 2019-02-06 05:28:26 UTC
I agree that this is somewhat unconventional and confusing, but the icon *does* change to indicate which split will be closed. Look carefully. :)
Comment 2 danbohea 2019-02-06 08:44:13 UTC
(In reply to Nate Graham from comment #1)
> I agree that this is somewhat unconventional and confusing, but the icon
> *does* change to indicate which split will be closed. Look carefully. :)

Ha! You're right, I hadn't noticed that before - which I guess is pretty telling in itself.

Now what about if the user has configured the toolbar to display text labels without icons?

I disagree that this is resolved and it certainly doesn't "work for me" but I'm new around these parts so will tread carefully and leave the issue status well alone! :)
Comment 3 Nate Graham 2019-02-06 19:03:23 UTC
Yeah, we're well aware that the "closing split views" UX could be improved. Personally I'm rooting for one close button per split, actually located ON the view itself, which would make it 100% obvious which one will be closed.
Comment 4 danbohea 2019-02-07 08:37:36 UTC
I agree that a close button per split pane would be an improvement.