| Summary: | Cropped notification indicator and unexpected transition shadow when zoomed | ||
|---|---|---|---|
| Product: | [Unmaintained] lattedock | Reporter: | Viorel-Cătălin Răpițeanu <rapiteanu.catalin> |
| Component: | application | Assignee: | Michail Vourlakos <mvourlakos> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | ||
| Priority: | NOR | ||
| Version First Reported In: | git (master) | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/latte-dock/9851a71293a1bd4841a34597c4369489d26d7112 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Application switch highlight issue. | ||
|
Description
Viorel-Cătălin Răpițeanu
2019-01-22 21:40:36 UTC
Video of the issue: https://drive.google.com/open?id=1ZR5jXB5UWxtHlD3Hr8DEIiUoKrx2Lott Git commit c3ddce3c864bc85ef8b547fd767efdf19b805c6e by Michail Vourlakos. Committed on 23/01/2019 at 20:47. Pushed by mvourlakos into branch 'master'. improve Tasks IconItem visuals/badges positioning --in order to be able to draw correctly the badges when they exceed the tasks boundaries the effects needed to be repositioned in Task/IconItem. So now shadows/colorizers etc. provide better freedom from code point of view. M +94 -42 plasmoid/package/contents/ui/task/IconItem.qml https://commits.kde.org/latte-dock/c3ddce3c864bc85ef8b547fd767efdf19b805c6e The notification badge is displayed correctly right now. The issue of the transition shadow remained. Should I open a new ticket for that? When you set the notification for one app at 9999+ and you switch between icons remained. To see this easily, set the zoom level at 5% and use huge application icons. Created attachment 117625 [details]
Application switch highlight issue.
Git commit 37558dd20c7215e4164adb21ebf746e7441a9a3c by Michail Vourlakos. Committed on 23/01/2019 at 21:50. Pushed by mvourlakos into branch 'master'. dont include tasks badges at brightness effects M +57 -42 plasmoid/package/contents/ui/task/IconItem.qml https://commits.kde.org/latte-dock/37558dd20c7215e4164adb21ebf746e7441a9a3c (In reply to Viorel-Cătălin Răpițeanu from comment #3) > The issue of the transition shadow remained. Should I open a new ticket for that? yes please and provide a video demonstrating with the latest commits because in your current video I can not notice any problem with shadows > Git commit 37558dd20c7215e4164adb21ebf746e7441a9a3c by Michail Vourlakos.
Everything is working as expected using the latest commit. Thanks.
Related to this change, there is another small papercut when the application with the notification badge is the first application in the dock. I'll add a video for that issue soon. Badge crop when the dock is not focused: https://drive.google.com/open?id=1_9HRguzUrW78LSSYSBdG8nXZvr6JV90h (In reply to Viorel-Cătălin Răpițeanu from comment #9) > Badge crop when the dock is not focused: > https://drive.google.com/open?id=1_9HRguzUrW78LSSYSBdG8nXZvr6JV90h Unfortunately this can be solved by making sure that the Info badge is always at the limits of the task size. That means that 9999+ could just change to 999+ That could be a solution. Git commit 9851a71293a1bd4841a34597c4369489d26d7112 by Michail Vourlakos. Committed on 24/01/2019 at 13:29. Pushed by mvourlakos into branch 'master'. elide InfoBadge for first task when needed M +4 -0 liblatte2/qml/BadgeText.qml M +4 -1 plasmoid/package/contents/ui/task/ProgressOverlay.qml https://commits.kde.org/latte-dock/9851a71293a1bd4841a34597c4369489d26d7112 That looks really good. Thanks for looking into this. |