Bug 403508

Summary: animated brush tips have wrong selection mode
Product: [Applications] krita Reporter: noemie scherer <noemie.scherer>
Component: Brush enginesAssignee: vanyossi <ghevan>
Status: RESOLVED FIXED    
Severity: normal CC: ghevan, griffinvalley
Priority: NOR    
Version First Reported In: 4.1.7   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description noemie scherer 2019-01-22 16:24:43 UTC
SUMMARY
When saving a new animated brush tip, the names of the Selection Mode are wrong. Each one actually saves to another Selection Mode (constant saves to random, pressure to increment, etc.)

STEPS TO REPRODUCE
1. In a new document (64*64 for example), create ten concentric full circles on different layers, each bigger than the previous one, and remove the default layers (the empty one and the white one)
2. Open the Brush Editor (f5); select a brush using the pixel engine, and uncheck all of its settings that use the Pen Settings (it is especially important that "Size" be unchecked, for legibility of the bug)
3. In "Brush Tip" > Predefined, click "Stamp"
4. Name your stamp "test_const", set Style to "Animated" and Selection Mode to "Constant", then click ok.
5. Redo 2. and 3.. Name your stamp "test_rand", set Style to "Animated", Selection Mode to "Random", click ok.
6. Redo 2. and 3.. Name your stamp "test_press", set Style to "Animated", Selection Mode to "Pressure", click ok.
7. Redo 2.. In "Brush Tip" > Predefined, select each of your stamps in turn while paying attention to the brush preview in the upper left.
8. (if you want) redo 7. but instead of looking at the brush preview, between each change of stamp, try it out on the canvas.

OBSERVED RESULT
with "test_const", the brush preview looks like random ink drops, with "test_press" it shows a pattern like several slugs (small, getting bigger, then suddenly small again, growing again, small, progressively bigger...).

EXPECTED RESULT
with "test_const" it should always have the same size, and with "test_press" it should be small on the left and progressively bigger going to the right.

SOFTWARE/OS VERSIONS
Fedora 27
Comment 1 wolthera 2019-04-08 15:33:12 UTC
This may have been fixed in master, as I cannot reproduce it currently.

Can you check with the latest nightly('Krita Next' on the downloads page)?
Comment 2 Bug Janitor Service 2019-04-23 04:33:20 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 vanyossi 2019-04-23 15:33:45 UTC
I can confirm this bug in 86b7e6073b19


Note: When creating animation tip, changing selection mode does not trigger a change.

WORKAROUND: 
1. Open new stam animated.
2. Set to desired selection mode
3. Hit cancel
4. Open again and hit ok
5. Animatino tip will be in correct mode
Comment 4 vanyossi 2019-05-03 23:20:01 UTC
Git commit 81407392c72f8b1b8d9ac9fb703486e506a7fbd4 by Ivan Yossi.
Committed on 03/05/2019 at 23:14.
Pushed by ivany into branch 'master'.

Fix missing event on animation stamp creation

M  +1    -0    plugins/paintops/libpaintop/kis_custom_brush_widget.cpp

https://invent.kde.org/kde/krita/commit/81407392c72f8b1b8d9ac9fb703486e506a7fbd4