Bug 403487

Summary:	No bankdata for payeeidentifier_iban_bic available
Product:	[Applications] kmymoney	Reporter:	Ralf Habacker <ralf.habacker>
Component:	onlinebanking	Assignee:	KMyMoney Devel Mailing List <kmymoney-devel>
Status:	REOPENED ---
Severity:	normal
Priority:	NOR
Version:	4.8.2
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:	https://commits.kde.org/kmymoney/d2e155cecafcc7e500ee4f16aad5e2a3f353fe6f	Version Fixed In:	4.8.3
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	403474

Description Ralf Habacker 2019-01-22 07:52:10 UTC

KMyMoney installs a library named payeeidentifier_iban_bic, which supports bankdata lookup. This library uses sqlite databases containing bank data (the source code says that banks from germany and switzerland are supported).
Unfortunally the generating of those databases has been disabled, so that this library is currently useless.

How to reproduce
See
-  https://cgit.kde.org/kmymoney.git/tree/kmymoney/plugins/ibanbicdata/CMakeLists.txt?h=4.8
- https://cgit.kde.org/kmymoney.git/tree/kmymoney/plugins/ibanbicdata/CMakeLists.txt?h=5.0
- https://cgit.kde.org/kmymoney.git/tree/kmymoney/plugins/ibanbicdata/CMakeLists.txt?h=master

Additional informations
This problem affects Branches 4.8, 5.0 and master.

Comment 1 Ralf Habacker 2019-01-25 21:40:31 UTC

Git commit 59e70ffa6d93cc279bd6aca0a741ca56b5ecb036 by Ralf Habacker.
Committed on 25/01/2019 at 21:40.
Pushed by habacker into branch '4.8-alkimia-onlinequote'.

Add actual bankdata files to not been bound on internet access for generating sqlite database

A  +16434 -0    kmymoney/plugins/ibanbicdata/germany/bankdata.de.txt
A  +3329 -0    kmymoney/plugins/ibanbicdata/switzerland/bankdata.ch.txt

https://commits.kde.org/kmymoney/59e70ffa6d93cc279bd6aca0a741ca56b5ecb036

Comment 2 Ralf Habacker 2019-01-25 21:40:32 UTC

Git commit 76334b052397119d2a0cc27a90d3987bf642bf05 by Ralf Habacker.
Committed on 25/01/2019 at 21:40.
Pushed by habacker into branch '4.8-alkimia-onlinequote'.

Restore support for generating bank data sqlite databases

M  +2    -0    kmymoney/payeeidentifier/ibanandbic/CMakeLists.txt
M  +3    -1    kmymoney/payeeidentifier/ibanandbic/ibanbicdata.h
M  +10   -12   kmymoney/payeeidentifier/ibanandbic/tests/internationalaccountidentifiertest.cpp
M  +2    -2    kmymoney/plugins/ibanbicdata/CMakeLists.txt
M  +23   -1    kmymoney/plugins/ibanbicdata/germany/CMakeLists.txt
M  +1    -1    kmymoney/plugins/ibanbicdata/germany/germany.py
M  +24   -2    kmymoney/plugins/ibanbicdata/switzerland/CMakeLists.txt

https://commits.kde.org/kmymoney/76334b052397119d2a0cc27a90d3987bf642bf05

Comment 3 Ralf Habacker 2019-01-26 21:52:42 UTC

Plugin now has the required data and the related test case also does not fail. The remaining question is now, where this plugin in used in kmymoney and how could this be tested.

Comment 4 Ralf Habacker 2019-01-26 22:17:35 UTC

Git commit 2e8a45bb936317cb7490117ef29edf1e93ddd5f7 by Ralf Habacker.
Committed on 26/01/2019 at 22:16.
Pushed by habacker into branch '4.8-staging'.

Restore support for generating bank data sqlite databases

M  +2    -0    kmymoney/payeeidentifier/ibanandbic/CMakeLists.txt
M  +3    -1    kmymoney/payeeidentifier/ibanandbic/ibanbicdata.h
M  +10   -12   kmymoney/payeeidentifier/ibanandbic/tests/internationalaccountidentifiertest.cpp
M  +2    -2    kmymoney/plugins/ibanbicdata/CMakeLists.txt
M  +23   -1    kmymoney/plugins/ibanbicdata/germany/CMakeLists.txt
M  +1    -1    kmymoney/plugins/ibanbicdata/germany/germany.py
M  +24   -2    kmymoney/plugins/ibanbicdata/switzerland/CMakeLists.txt

https://commits.kde.org/kmymoney/2e8a45bb936317cb7490117ef29edf1e93ddd5f7

Comment 5 Ralf Habacker 2019-01-26 22:17:35 UTC

Git commit 3a6c92d6fd07c7d5138d1d1fe01eb802d339a7b9 by Ralf Habacker.
Committed on 26/01/2019 at 22:17.
Pushed by habacker into branch '4.8-staging'.

Create bankdata db file in the source directory to make it easier to add it to git

M  +9    -9    kmymoney/plugins/ibanbicdata/germany/CMakeLists.txt
M  +6    -6    kmymoney/plugins/ibanbicdata/switzerland/CMakeLists.txt

https://commits.kde.org/kmymoney/3a6c92d6fd07c7d5138d1d1fe01eb802d339a7b9

Comment 6 Ralf Habacker 2019-01-26 22:17:35 UTC

Git commit 2d1b9285d11f57a70c1d05a80d115ed560894468 by Ralf Habacker.
Committed on 26/01/2019 at 22:17.
Pushed by habacker into branch '4.8-staging'.

Add actual bankdata files to not been bound on internet access for generating sqlite database

A  +16434 -0    kmymoney/plugins/ibanbicdata/germany/bankdata.de.txt
A  +3329 -0    kmymoney/plugins/ibanbicdata/switzerland/bankdata.ch.txt

https://commits.kde.org/kmymoney/2d1b9285d11f57a70c1d05a80d115ed560894468

Comment 7 Ralf Habacker 2019-01-26 22:17:35 UTC

Git commit be4ce97b010931b38599849463ef7c9a1c242570 by Ralf Habacker.
Committed on 26/01/2019 at 22:17.
Pushed by habacker into branch '4.8-staging'.

Add bankdata sql files to fix python issue on obs

A  +-    --    kmymoney/plugins/ibanbicdata/germany/bankdata.de.db
A  +-    --    kmymoney/plugins/ibanbicdata/switzerland/bankdata.ch.db

https://commits.kde.org/kmymoney/be4ce97b010931b38599849463ef7c9a1c242570

Comment 8 Ralf Habacker 2019-02-25 11:36:37 UTC

Git commit 44cfe7e9998a003875295a35045eea06514b19e5 by Ralf Habacker.
Committed on 25/02/2019 at 10:10.
Pushed by habacker into branch '4.8'.

Restore support for generating bank data sqlite databases

Summary:
Add actual bankdata files to not been bound on internet access for generating sqlite database
FIXED-IN:4.8.3

Test Plan: tested on linux

Reviewers: tbaumgart

Differential Revision: https://phabricator.kde.org/D18447

M  +2    -0    kmymoney/payeeidentifier/ibanandbic/CMakeLists.txt
M  +3    -1    kmymoney/payeeidentifier/ibanandbic/ibanbicdata.h
M  +10   -12   kmymoney/payeeidentifier/ibanandbic/tests/internationalaccountidentifiertest.cpp
M  +2    -2    kmymoney/plugins/ibanbicdata/CMakeLists.txt
M  +23   -1    kmymoney/plugins/ibanbicdata/germany/CMakeLists.txt
A  +16434 -0    kmymoney/plugins/ibanbicdata/germany/bankdata.de.txt
M  +1    -1    kmymoney/plugins/ibanbicdata/germany/germany.py
M  +24   -2    kmymoney/plugins/ibanbicdata/switzerland/CMakeLists.txt
A  +3329 -0    kmymoney/plugins/ibanbicdata/switzerland/bankdata.ch.txt

https://commits.kde.org/kmymoney/44cfe7e9998a003875295a35045eea06514b19e5

Comment 9 Ralf Habacker 2019-03-02 19:59:52 UTC

Git commit d2e155cecafcc7e500ee4f16aad5e2a3f353fe6f by Ralf Habacker.
Committed on 02/03/2019 at 19:58.
Pushed by habacker into branch '4.8-staging'.

Restore support for generating bank data sqlite databases

Summary:
Add actual bankdata files to not been bound on internet access for generating sqlite database
FIXED-IN:4.8.3

Test Plan: tested on linux

Reviewers: tbaumgart

Differential Revision: https://phabricator.kde.org/D18447

M  +2    -0    kmymoney/payeeidentifier/ibanandbic/CMakeLists.txt
M  +3    -1    kmymoney/payeeidentifier/ibanandbic/ibanbicdata.h
M  +10   -12   kmymoney/payeeidentifier/ibanandbic/tests/internationalaccountidentifiertest.cpp
M  +2    -2    kmymoney/plugins/ibanbicdata/CMakeLists.txt
M  +23   -1    kmymoney/plugins/ibanbicdata/germany/CMakeLists.txt
A  +16434 -0    kmymoney/plugins/ibanbicdata/germany/bankdata.de.txt
M  +1    -1    kmymoney/plugins/ibanbicdata/germany/germany.py
M  +24   -2    kmymoney/plugins/ibanbicdata/switzerland/CMakeLists.txt
A  +3329 -0    kmymoney/plugins/ibanbicdata/switzerland/bankdata.ch.txt

https://commits.kde.org/kmymoney/d2e155cecafcc7e500ee4f16aad5e2a3f353fe6f

Comment 10 Ralf Habacker 2019-03-02 20:17:01 UTC

Git commit fb54491ad00ea1ba9aea7dbf393aa71aaf2041b5 by Ralf Habacker.
Committed on 02/03/2019 at 19:58.
Pushed by habacker into branch '4.8-staging'.

Add bankdata sql files to fix python issue on obs

A  +-    --    kmymoney/plugins/ibanbicdata/germany/bankdata.de.db
A  +-    --    kmymoney/plugins/ibanbicdata/switzerland/bankdata.ch.db

https://commits.kde.org/kmymoney/fb54491ad00ea1ba9aea7dbf393aa71aaf2041b5

Comment 11 Ralf Habacker 2019-03-02 20:17:04 UTC

Git commit 962240aecae89632e2ae87084cede8ef0e1e48a9 by Ralf Habacker.
Committed on 02/03/2019 at 19:58.
Pushed by habacker into branch '4.8-staging'.

Create bankdata db file in the source directory to make it easier to add it to git

M  +9    -9    kmymoney/plugins/ibanbicdata/germany/CMakeLists.txt
M  +6    -6    kmymoney/plugins/ibanbicdata/switzerland/CMakeLists.txt

https://commits.kde.org/kmymoney/962240aecae89632e2ae87084cede8ef0e1e48a9

Comment 12 Ralf Habacker 2019-03-04 15:56:57 UTC

Git commit e98a99a3acead0dcead45467b6b51ef05c840b6d by Ralf Habacker.
Committed on 04/03/2019 at 12:05.
Pushed by habacker into branch '4.8-staging'.

Add bankdata sql files to fix python issue on obs

A  +-    --    kmymoney/plugins/ibanbicdata/germany/bankdata.de.db
A  +-    --    kmymoney/plugins/ibanbicdata/switzerland/bankdata.ch.db

https://commits.kde.org/kmymoney/e98a99a3acead0dcead45467b6b51ef05c840b6d

Comment 13 Ralf Habacker 2019-03-04 15:56:57 UTC

Git commit b3774441761bd6d59413c23033cfe03d12b0f167 by Ralf Habacker.
Committed on 04/03/2019 at 12:05.
Pushed by habacker into branch '4.8-staging'.

Create bankdata db file in the source directory to make it easier to add it to git

M  +9    -9    kmymoney/plugins/ibanbicdata/germany/CMakeLists.txt
M  +6    -6    kmymoney/plugins/ibanbicdata/switzerland/CMakeLists.txt

https://commits.kde.org/kmymoney/b3774441761bd6d59413c23033cfe03d12b0f167

Comment 14 Ralf Habacker 2019-03-26 23:26:09 UTC

Git commit 98bdeda61aeccbe5fb13b81c0b9fe69ecd74aee0 by Ralf Habacker.
Committed on 26/03/2019 at 23:24.
Pushed by habacker into branch '4.8-staging'.

Create bankdata db file in the source directory to make it easier to add it to git

M  +9    -9    kmymoney/plugins/ibanbicdata/germany/CMakeLists.txt
M  +6    -6    kmymoney/plugins/ibanbicdata/switzerland/CMakeLists.txt

https://commits.kde.org/kmymoney/98bdeda61aeccbe5fb13b81c0b9fe69ecd74aee0

Comment 15 Ralf Habacker 2019-03-26 23:26:11 UTC

Git commit 96561163cb8bc5f11be1207cb71e0aef741cfd61 by Ralf Habacker.
Committed on 26/03/2019 at 23:24.
Pushed by habacker into branch '4.8-staging'.

Add bankdata sql files to fix python issue on obs

A  +-    --    kmymoney/plugins/ibanbicdata/germany/bankdata.de.db
A  +-    --    kmymoney/plugins/ibanbicdata/switzerland/bankdata.ch.db

https://commits.kde.org/kmymoney/96561163cb8bc5f11be1207cb71e0aef741cfd61

Comment 16 Ralf Habacker 2019-08-30 15:55:33 UTC

The bankdata is only in 4.8-staging branch and not in 4.8.