| Summary: | Plotter doesn't handle QQuickWindow::sceneGraphInvalidated | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kdeclarative | Reporter: | techxgames |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | aaaSashaMGGU, abyss.7, adnet_9, alex.obenza, alex300026, andriy1898k, annunah, arberarcher, asocial.bastard3, babrovich, bailong104, bugseforuns, chris+kdebug, info, isirasen96, kde, kde, kdelibs-bugs, nate, plasma-bugs, postix, pvonbert, tecdoor_17, valkai.mate, weisswilly1985 |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 5.52.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kdeclarative/0aab7d23a2ce155c4beb5cf77fcac02c93b183b7 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
techxgames
2019-01-21 08:24:47 UTC
Crashes in the plotter, probably here: s_program->bind(); s_program->setUniformValue(u_matrix, m_matrix); Are you on nvidia? *** Bug 402198 has been marked as a duplicate of this bug. *** (In reply to Kai Uwe Broulik from comment #1) > Crashes in the plotter, probably here: > > s_program->bind(); > s_program->setUniformValue(u_matrix, m_matrix); > > Are you on nvidia? yes My bad Thought I replied to this bug report *** Bug 368071 has been marked as a duplicate of this bug. *** *** Bug 349289 has been marked as a duplicate of this bug. *** Git commit 0aab7d23a2ce155c4beb5cf77fcac02c93b183b7 by David Edmundson. Committed on 18/04/2019 at 16:14. Pushed by davidedmundson into branch 'master'. Plotter: Scope GL Program to lifespan of scenegraph node Summary: Currently the QOpenGLProgram was static. This works when you only have one OpenGL context that is never invalidated. Instead we shoul have a new program created for each context. There is no benefit of being static when we can use the cached shader loading. As we need a program per context, we would need to handle windowChanged and sceneGraphInvalidated manually. Instead we can scope the program to the QSGNode which will be deleted and recreated on the render thread automatically by the scene graph backend. We can also drop ManagedTextureNode and use QSGSimpleTextureNode::setOwnsTexture which does the same thing. Test Plan: Created a CPU load viewer on my panel Dragged it to my desktop Previously that didn't render anything Now it does It should fix the crashes that we see on window moves and handling sceneGraphInvalidated Reviewers: #plasma Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D20656 M +66 -40 src/qmlcontrols/kquickcontrolsaddons/plotter.cpp M +2 -9 src/qmlcontrols/kquickcontrolsaddons/plotter.h https://commits.kde.org/kdeclarative/0aab7d23a2ce155c4beb5cf77fcac02c93b183b7 *** Bug 408540 has been marked as a duplicate of this bug. *** *** Bug 403727 has been marked as a duplicate of this bug. *** *** Bug 385731 has been marked as a duplicate of this bug. *** *** Bug 408751 has been marked as a duplicate of this bug. *** *** Bug 408641 has been marked as a duplicate of this bug. *** *** Bug 409709 has been marked as a duplicate of this bug. *** *** Bug 410078 has been marked as a duplicate of this bug. *** *** Bug 410635 has been marked as a duplicate of this bug. *** *** Bug 410005 has been marked as a duplicate of this bug. *** *** Bug 410648 has been marked as a duplicate of this bug. *** *** Bug 415195 has been marked as a duplicate of this bug. *** *** Bug 415825 has been marked as a duplicate of this bug. *** *** Bug 418892 has been marked as a duplicate of this bug. *** *** Bug 424174 has been marked as a duplicate of this bug. *** *** Bug 427280 has been marked as a duplicate of this bug. *** *** Bug 420103 has been marked as a duplicate of this bug. *** |